Chore/move golang code #447
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
AtomicFS
force-pushed
the
chore/move-golang-code
branch
5 times, most recently
from
f57ec20 to
f710eae
Compare
AtomicFS
force-pushed
the
chore/move-golang-code
branch
from
f710eae to
94ca55c
Compare
AtomicFS
force-pushed
the
chore/move-golang-code
branch
2 times, most recently
from
d4c2db2 to
05a071e
Compare
AtomicFS
force-pushed
the
chore/move-golang-code
branch
from
05a071e to
2f93621
Compare
|
Does this work as expected btw? If I recall correctly the reason to change it was due to how |
Yes, that is the reason. It should work, but I do not know how to actually test it. |
AtomicFS
force-pushed
the
chore/move-golang-code
branch
from
2f93621 to
3a82035
Compare
|
I'll try to test this out from the branch soon to check if this does what we want. |
- 'go install' command uses the last elements in the path/url to determine name of the executable - move golang code from ./action directory to ./cmd/firmware-action instead - this way when people run 'go install' they get 'firmware-action' instead of just 'action' Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
- change references in docs - update gitignore - update workflows - update Taskfile - hopefully I did not forget anything Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
AtomicFS
force-pushed
the
chore/move-golang-code
branch
from
3a82035 to
bd99632
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.