feat(action): check for any undefined environment variable in config #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtomicFS
force-pushed
the
feat/undefined-env-vars
branch
3 times, most recently
from
99b7ddb to
07cb90e
Compare
MDr164
reviewed
Dec 3, 2024
- until now it was rather hard to debug when the issue was one or more missing environment variables - with this patch, all environment detected variables in the JSON configuration file must be defined at the time of execution Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
AtomicFS
force-pushed
the
feat/undefined-env-vars
branch
from
07cb90e to
405ad6c
Compare
MDr164
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golang's os.ExpandEnv does not perform such check:
fixes #384