Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump dagger.io/dagger from 0.14.0 to 0.15.1 in /action #482

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 18, 2024

Bumps dagger.io/dagger from 0.14.0 to 0.15.1.

Changelog

Sourced from dagger.io/dagger's changelog.

sdk/go/v0.15.1 - 2024-12-12

This SDK uses 🚙 Engine + 🚗 CLI version v0.15.1. See what changed in that release.

🐹 https://pkg.go.dev/dagger.io/dagger@v0.15.1

Dependencies

What to do next

sdk/go/v0.15.0 - 2024-12-11

This SDK uses 🚙 Engine + 🚗 CLI version v0.15.0. See what changed in that release.

🐹 https://pkg.go.dev/dagger.io/dagger@v0.15.0

🔥 Breaking Changes

  • Removed deprecated unscoped enum values by @​jedevc in dagger/dagger#8669
    Enum values must now be accessed with the name prefixed by the name of the enum type - for example, dagger.Shared becomes dagger.CacheSharingModeLocked.
  • ExecErr.Error no longer contains the values of Stdout or Stderr by @​vito in dagger/dagger#9033
    When comparing error values for expected output, use the more specific values.

Dependencies

What to do next

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested review from MDr164 and AtomicFS as code owners December 18, 2024 16:37
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Dec 18, 2024
@AtomicFS AtomicFS enabled auto-merge December 18, 2024 16:37
@dependabot dependabot bot force-pushed the dependabot/go_modules/action/dagger.io/dagger-0.15.1 branch from 8afa334 to 79d1504 Compare December 18, 2024 16:58
AtomicFS
AtomicFS previously approved these changes Dec 18, 2024
@MDr164 MDr164 force-pushed the dependabot/go_modules/action/dagger.io/dagger-0.15.1 branch from 79d1504 to 59ddf84 Compare December 19, 2024 11:18
@MDr164
Copy link
Collaborator

MDr164 commented Dec 19, 2024

Looks like the only failing check here is the CVE check on an indirect dep so far.

@AtomicFS
Copy link
Collaborator

If the go-test works fine, then just merge by bypassing the rules.

@MDr164
Copy link
Collaborator

MDr164 commented Dec 19, 2024

I just bumped that particular indirect one as well, locally it was building just fine with it

@MDr164
Copy link
Collaborator

MDr164 commented Dec 19, 2024

Looks like it's getting stuck somewhere, likely #476 I suppose?

@AtomicFS
Copy link
Collaborator

That is certainly possible. Which is the reason why we could not merge #482 yet. I just don't know why it is getting stuck, and I can't be bothered at the moment to debug it (if it is still relevant I will take a look after Christmas).

If it fails in 60 minutes, then it is definitely #476.

@MDr164
Copy link
Collaborator

MDr164 commented Dec 19, 2024

Same thing happens locally. Let me check if the timeout of 5s resolves it and I'll update both PRs.

@AtomicFS
Copy link
Collaborator

#476 does not resolve it, it just makes it fail faster.

@AtomicFS
Copy link
Collaborator

Must be some kind of breaking change in dagger v0.15.x.

@MDr164
Copy link
Collaborator

MDr164 commented Dec 19, 2024

Yep, adding the timeout un-stucks the test. I'll try to find out what was changed for dagger to behave different here now.

@MDr164
Copy link
Collaborator

MDr164 commented Dec 19, 2024

sshServiceTunnel, err := client.Host().Tunnel(sshServiceDoc).Start(ctx) this line in ssh.go blocks indefinitely for whatever reason...

@AtomicFS
Copy link
Collaborator

So, basically, I think that it would be better to drop the whole SSH feature and replace it with #269. Especially if fixing the SSH will take long time, it might be better investment.

Do you know how severe is the security 12 issue? The previous one security issue 11 had minimal impact since it was affecting only testing.

Bumps [dagger.io/dagger](https://github.com/dagger/dagger-go-sdk) from 0.14.0 to 0.15.1.
- [Changelog](https://github.com/dagger/dagger-go-sdk/blob/main/CHANGELOG.md)
- [Commits](dagger/dagger-go-sdk@v0.14.0...v0.15.1)

---
updated-dependencies:
- dependency-name: dagger.io/dagger
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@AtomicFS AtomicFS force-pushed the dependabot/go_modules/action/dagger.io/dagger-0.15.1 branch from f85430e to f25dd9e Compare December 21, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants