add cli #89
Merged
add cli #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rework the entire structure of passing data along - instead of passing githubaction.Action, pass config structures - add support for parsing JSON file - add support for usign JSON as configuration file - use go-playground/validator to validate JSON config
AtomicFS
force-pushed
the
feat/cli
branch
5 times, most recently
from
c703e37 to
c416d83
Compare
|
Found a few bugs upon making a pull request, but they all should be fixed by now. Consider it review ready. Test with edk2 complains about something during the build, but I am not sure what is the problem - probably wrong path? |
|
FYI, the problem with edk2 was somehow fixed ... |
MDr164
approved these changes
Jan 18, 2024
AtomicFS
added
github_actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move away from using GitHub actions to use JSON configuration file instead. This allows to use the
firmware-actionthe exact same way in local system just like in CI/CD pipeline with the same input (JSON config file).Fixes issue #88 , but is still missing recursive build of dependencies.