Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursive build of dependencies #90

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Recursive build of dependencies #90

merged 2 commits into from
Jan 18, 2024

Conversation

AtomicFS
Copy link
Collaborator

@AtomicFS AtomicFS commented Jan 8, 2024

No description provided.

@AtomicFS AtomicFS added feature New feature or request github actions labels Jan 8, 2024
@AtomicFS AtomicFS force-pushed the feat/recursive_dep branch 3 times, most recently from 6487bb1 to 310a98f Compare January 8, 2024 17:45
MDr164
MDr164 previously approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@MDr164 MDr164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are just some minor style issues but as the current linters don't complain I'll let those pass. Functionally-wise it looks fine, couldn't spot anything. 👍

Base automatically changed from feat/cli to main January 18, 2024 14:51
@AtomicFS AtomicFS dismissed MDr164’s stale review January 18, 2024 14:51

The base branch was changed.

@AtomicFS AtomicFS requested a review from MDr164 January 18, 2024 15:08
@AtomicFS AtomicFS enabled auto-merge January 18, 2024 15:08
MDr164
MDr164 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@MDr164 MDr164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as no change since rebase

@AtomicFS AtomicFS added this pull request to the merge queue Jan 18, 2024
Merged via the queue into main with commit 09c3ffe Jan 18, 2024
25 checks passed
@AtomicFS AtomicFS deleted the feat/recursive_dep branch January 18, 2024 16:29
@AtomicFS AtomicFS added github_actions Pull requests that update GitHub Actions code and removed github actions labels Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDr164 MDr164 MDr164 approved these changes

Assignees
No one assigned
Labels
feature New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AtomicFS @MDr164