Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation hosted in pages #91

Merged
merged 8 commits into from
Jan 23, 2024
Merged

add documentation hosted in pages #91

merged 8 commits into from
Jan 23, 2024

Conversation

AtomicFS
Copy link
Collaborator

@AtomicFS AtomicFS commented Jan 12, 2024

fixes #21

@AtomicFS AtomicFS added the documentation Improvements or additions to documentation label Jan 12, 2024
@AtomicFS AtomicFS force-pushed the docs/write_docs branch 2 times, most recently from 7b71d85 to 95052ee Compare January 17, 2024 10:27
@AtomicFS AtomicFS force-pushed the docs/write_docs branch 2 times, most recently from 41307f5 to dd3a914 Compare January 18, 2024 15:12
Base automatically changed from feat/recursive_dep to main January 18, 2024 16:29
@AtomicFS AtomicFS requested a review from MDr164 January 18, 2024 16:33
@AtomicFS AtomicFS enabled auto-merge January 18, 2024 16:42
@MDr164
Copy link
Collaborator

MDr164 commented Jan 22, 2024

As an idea: Can we link docs in our pkg.go.dev page as well? Most of the time this is where people look for initial function/method level documentation so linking to more context from there would make sense imo. For instance the changes to the README will already be reflected there so the general link will be available. My idea would be to extend that onto the text markers you created if that is possible. Otherwise good work adding more docs!

@AtomicFS
Copy link
Collaborator Author

AtomicFS commented Jan 22, 2024

I am not sure if I understand what you mean. Posting a link to https://pkg.go.dev is fine by me, although I have no clue how.

My idea would be to extend that onto the text markers you created if that is possible.

Sorry but you completely lost me here. extend that onto the text markers?

Otherwise good work adding more docs!

Thanks! I am still working on documenting how the docker containers with the fake docker compose work.

EDIT: Never mind, apparently I have already done that :D

@AtomicFS
Copy link
Collaborator Author

@MDr164 do I understand correctly that I just need to add link to mdbook docs at action/main.go?

That should then appear in pkg.go.dev/firmware-action.

So like:

 // SPDX-License-Identifier: MIT
 
 // Package main implements the core logic of running composable Dagger pipelines
+// Documentation [is hosted in GitHub pages](https://9elements.github.io/firmware-action/)
 package main
 
 import (

@MDr164
Copy link
Collaborator

MDr164 commented Jan 22, 2024

I suppose yes. I'm also not 100% sure right now which package doc gets rendered where but that looks about right. In addition the README will also be rendered so as you're putting the link there it will already link to the main docs page from the README here and the one at go.dev

@AtomicFS
Copy link
Collaborator Author

Added the comment. I hope it is sufficient.

@AtomicFS AtomicFS added this pull request to the merge queue Jan 23, 2024
Merged via the queue into main with commit 22f075f Jan 23, 2024
25 checks passed
@AtomicFS AtomicFS deleted the docs/write_docs branch January 23, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to use this action
2 participants