-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add documentation hosted in pages #91
Conversation
7b71d85
to
95052ee
Compare
0f67c94
to
9a1b3d7
Compare
41307f5
to
dd3a914
Compare
dd3a914
to
36a29d4
Compare
As an idea: Can we link docs in our pkg.go.dev page as well? Most of the time this is where people look for initial function/method level documentation so linking to more context from there would make sense imo. For instance the changes to the README will already be reflected there so the general link will be available. My idea would be to extend that onto the text markers you created if that is possible. Otherwise good work adding more docs! |
I am not sure if I understand what you mean. Posting a link to https://pkg.go.dev is fine by me, although I have no clue how.
Sorry but you completely lost me here.
Thanks! EDIT: Never mind, apparently I have already done that :D |
36a29d4
to
3ef9e3c
Compare
@MDr164 do I understand correctly that I just need to add link to mdbook docs at action/main.go? That should then appear in pkg.go.dev/firmware-action. So like: // SPDX-License-Identifier: MIT
// Package main implements the core logic of running composable Dagger pipelines
+// Documentation [is hosted in GitHub pages](https://9elements.github.io/firmware-action/)
package main
import ( |
I suppose yes. I'm also not 100% sure right now which package doc gets rendered where but that looks about right. In addition the README will also be rendered so as you're putting the link there it will already link to the main docs page from the README here and the one at go.dev |
Added the comment. I hope it is sufficient. |
fixes #21