Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor edk2 #93

Closed
wants to merge 11 commits into from
Closed

refactor edk2 #93

wants to merge 11 commits into from

Conversation

AtomicFS
Copy link
Collaborator

@AtomicFS AtomicFS commented Jan 16, 2024

fixes issue #92

Refactor EDK2 to give more flexibility ???

I am actually not sure about this. The idea was to open up the possibility of building Intel FSP, but I think that this PR is not that great. Some feedback would be nice.

  • move defconfig_path from common into specific since it is not required
    for edk2 builds (it is actually a hack)
  • edk2: read defconfig_path file only if provided and only if exists
  • a lot of code in edk2 was just commented out since it might be used
    later for simplification of usage by the end user

@AtomicFS AtomicFS added feature New feature or request github actions labels Jan 16, 2024
@AtomicFS AtomicFS added this to the Refactor the Go action milestone Jan 16, 2024
@AtomicFS AtomicFS force-pushed the feat/refactor_edk2 branch 3 times, most recently from 3be4c39 to 9870737 Compare January 17, 2024 10:22
- move defconfig_path from common into specific since it is not required
  for edk2 builds (it is actually a hack)
- edk2: read defconfig_path file only if provided and only if exists
- a lot of code in edk2 was just commented out since it might be used
  later for simplification of usage by the end user
@AtomicFS AtomicFS force-pushed the docs/write_docs branch 2 times, most recently from 36a29d4 to 3ef9e3c Compare January 22, 2024 10:01
@AtomicFS
Copy link
Collaborator Author

Obsolete - code changes moved to new branch and PR #95

@AtomicFS AtomicFS closed this Jan 22, 2024
@AtomicFS AtomicFS deleted the feat/refactor_edk2 branch January 23, 2024 11:15
@AtomicFS AtomicFS added github_actions Pull requests that update GitHub Actions code and removed github actions labels Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request github_actions Pull requests that update GitHub Actions code module/edk2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant