-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename/refactor in models for clarity #533
Open
NoRePercussions
wants to merge
12
commits into
ABTech:master
Choose a base branch
from
NoRePercussions:refactor/models
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Nov 16, 2023
-
Properly name class representing academic year
This was previously part of the accounts management, but that has since been removed.
Configuration menu - View commit details
-
Copy full SHA for eff2b85 - Browse repository at this point
Copy the full SHA eff2b85View commit details
Commits on Nov 17, 2023
-
Add intended effect to validator
Not prefixing with self makes subcategory a local variable, meaning that the method has no effect
Configuration menu - View commit details
-
Copy full SHA for 31679eb - Browse repository at this point
Copy the full SHA 31679ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 373fdd0 - Browse repository at this point
Copy the full SHA 373fdd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae5e9c3 - Browse repository at this point
Copy the full SHA ae5e9c3View commit details -
Mostly fix name pluralization and slight logic tweaks
Configuration menu - View commit details
-
Copy full SHA for 99e8f7a - Browse repository at this point
Copy the full SHA 99e8f7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f1bc98a - Browse repository at this point
Copy the full SHA f1bc98aView commit details -
This is not a very necessary refactor, it was fine as is. This is mostly done to mirror the same pattern in another model. Removing the nil checks will not give errors when sorting valid objects. If it is invalid or being constructed, that may be an issue.
Configuration menu - View commit details
-
Copy full SHA for 5e37928 - Browse repository at this point
Copy the full SHA 5e37928View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3244e71 - Browse repository at this point
Copy the full SHA 3244e71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0abc0ac - Browse repository at this point
Copy the full SHA 0abc0acView commit details
Commits on Feb 13, 2024
-
Even if objects are invalid (e.g. if an InvoiceLine has an invalid category), allow them to still be sorted without raising errors.
Configuration menu - View commit details
-
Copy full SHA for da8c3da - Browse repository at this point
Copy the full SHA da8c3daView commit details -
Clarify changes to equipment profile:
Self is needed in the null_subcategory helper to prevent it creating a local variable. It is not needed elsewhere. This is not a validation step; rather, it runs before validation. Either of blank or nil continues to be allowed.
Configuration menu - View commit details
-
Copy full SHA for 77bb967 - Browse repository at this point
Copy the full SHA 77bb967View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d10003 - Browse repository at this point
Copy the full SHA 9d10003View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.