Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename/refactor in models for clarity #533

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Commits on Nov 16, 2023

  1. Properly name class representing academic year

    This was previously part of the accounts management, but that has since been removed.
    NoRePercussions committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    eff2b85 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Add intended effect to validator

    Not prefixing with self makes subcategory a local variable, meaning that the method has no effect
    NoRePercussions committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    31679eb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    373fdd0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ae5e9c3 View commit details
    Browse the repository at this point in the history
  4. Clean event roles application

    Mostly fix name pluralization and slight logic tweaks
    NoRePercussions committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    99e8f7a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f1bc98a View commit details
    Browse the repository at this point in the history
  6. Rearrange sorting logic

    This is not a very necessary refactor, it was fine as is. This is mostly done to mirror the same pattern in another model.
    
    Removing the nil checks will not give errors when sorting valid objects. If it is invalid or being constructed, that may be an issue.
    NoRePercussions committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    5e37928 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3244e71 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0abc0ac View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Fix sort for invalid objects

    Even if objects are invalid (e.g. if an InvoiceLine has an invalid category), allow them to still be sorted without raising errors.
    NoRePercussions committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    da8c3da View commit details
    Browse the repository at this point in the history
  2. Clarify changes to equipment profile:

    Self is needed in the null_subcategory helper to prevent it creating a local variable. It is not needed elsewhere.
    
    This is not a validation step; rather, it runs before validation. Either of blank or nil continues to be allowed.
    NoRePercussions committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    77bb967 View commit details
    Browse the repository at this point in the history
  3. Fix typo

    NoRePercussions committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    9d10003 View commit details
    Browse the repository at this point in the history