Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Add custom fields for voting page #100

Merged

Conversation

gjaskiewicz
Copy link
Contributor

This is to partially address this issue
#28

I run it and verified that it works
image

@gjaskiewicz
Copy link
Contributor Author

@barbara-goeller Would you be able to take a look or find a reviewer?

@barbara-goeller
Copy link
Collaborator

barbara-goeller commented Oct 1, 2021

Hi @gjaskiewicz,
I will be on holidays the next week. But a colleague of mine will do the review and come back to you.

Best regards
Barbara

</label>
<br />
<label>
<input type="checkbox" name="useCustomFieldEffort" v-model="actualVoting.useCustomFieldEffort" />
Copy link
Contributor

@SirBlaumann SirBlaumann Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was very confused by the name.
In fact, that's why I was looking for custom fields.
But the fields that are used are the normal ones.

Please adjust the naming for useCustomFieldXXX.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SirBlaumann I renamed fields to useExtraInfoFieldXXX as well as I changed text in HTML

Copy link
Contributor

@SirBlaumann SirBlaumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Grzegorz,

After the agile approaches, this is definitely an added value and I could test it right away.
Functionally, this is very helpful.

Of course, it would be much nicer if you could variably select the column setting based on the existing columns.
Maybe you feel inspired to extend the column selection accordingly.

At least you should do the simple renaming as mentioned in the comment.

best regards
David

@gjaskiewicz
Copy link
Contributor Author

Hello Grzegorz,

After the agile approaches, this is definitely an added value and I could test it right away. Functionally, this is very helpful.

Of course, it would be much nicer if you could variably select the column setting based on the existing columns. Maybe you feel inspired to extend the column selection accordingly.

At least you should do the simple renaming as mentioned in the comment.

best regards David

I agree that it could be done in generic way, but given that I have limited knowledge in VUE and limited time to work on this feature, the best thing I could offer is to rename the fields right now.

@gjaskiewicz gjaskiewicz closed this Oct 7, 2021
@gjaskiewicz gjaskiewicz reopened this Oct 7, 2021
@gjaskiewicz
Copy link
Contributor Author

@SirBlaumann PTAL

@SirBlaumann
Copy link
Contributor

Your renaming is fine.
The function is not generic, but it is a helpful function.
I would like ta have it migrated into the main branch.

Thank you Grzegorz for your participation!

Now the ball is passed to @barbara-goeller.

@gjaskiewicz
Copy link
Contributor Author

@barbara-goeller could it be merged, please?

@DavidZart
Copy link

Hi Grzegorz,
I'll do it.
Because of my vacation, it may delay until next week.

@DavidZart DavidZart merged commit 0d196bf into AITGmbH:master Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants