-
Notifications
You must be signed in to change notification settings - Fork 8
Add custom fields for voting page #100
Add custom fields for voting page #100
Conversation
@barbara-goeller Would you be able to take a look or find a reviewer? |
Hi @gjaskiewicz, Best regards |
</label> | ||
<br /> | ||
<label> | ||
<input type="checkbox" name="useCustomFieldEffort" v-model="actualVoting.useCustomFieldEffort" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was very confused by the name.
In fact, that's why I was looking for custom fields.
But the fields that are used are the normal ones.
Please adjust the naming for useCustomFieldXXX.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SirBlaumann I renamed fields to useExtraInfoFieldXXX as well as I changed text in HTML
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Grzegorz,
After the agile approaches, this is definitely an added value and I could test it right away.
Functionally, this is very helpful.
Of course, it would be much nicer if you could variably select the column setting based on the existing columns.
Maybe you feel inspired to extend the column selection accordingly.
At least you should do the simple renaming as mentioned in the comment.
best regards
David
I agree that it could be done in generic way, but given that I have limited knowledge in VUE and limited time to work on this feature, the best thing I could offer is to rename the fields right now. |
@SirBlaumann PTAL |
Your renaming is fine. Thank you Grzegorz for your participation! Now the ball is passed to @barbara-goeller. |
@barbara-goeller could it be merged, please? |
Hi Grzegorz, |
This is to partially address this issue
#28
I run it and verified that it works