Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heat equation tutorial with pyamrex #96

Merged
merged 9 commits into from
Sep 19, 2023
Merged

Conversation

EZoni
Copy link
Contributor

@EZoni EZoni commented Jul 20, 2023

Thank you to @RevathiJambunathan, @oshapoval, @dpgrote, @kngott and @ax3l for the teamwork.

Rewrite the "HeatEquation" guided tutorial using pyamrex.

This depends on:

To-do:

  • Validate results (pyamrex vs C++)
  • Generalize numpy with cupy (CPU -> CPU, CUDA, HIP)

Follow-up ideas:

  • Use ParmParse to read input parameters
  • Make code dimension-agnostic as original C++ tutorial

Visualization of plotfile data produced with pyamrex, using yt:

heat-equation-phi

Comparison of plotfile data produced with pyamrex and C++, using ParaView, at step=100:

@ax3l ax3l added the enhancement New feature or request label Jul 24, 2023
@ax3l ax3l requested review from ax3l and atmyers July 24, 2023 02:09
GuidedTutorials/HeatEquation/Source/main.py Outdated Show resolved Hide resolved
GuidedTutorials/HeatEquation/Source/main.py Outdated Show resolved Hide resolved
GuidedTutorials/HeatEquation/Source/main.py Outdated Show resolved Hide resolved
GuidedTutorials/HeatEquation/Source/main.py Outdated Show resolved Hide resolved
GuidedTutorials/HeatEquation/Source/main.py Outdated Show resolved Hide resolved
@ax3l ax3l requested a review from WeiqunZhang July 24, 2023 02:17
@ax3l
Copy link
Member

ax3l commented Jul 24, 2023

reopening for CI update from #97

@ax3l ax3l closed this Jul 24, 2023
@ax3l ax3l reopened this Jul 24, 2023
@ax3l ax3l force-pushed the pyHeatEquation branch 2 times, most recently from 5e20fdf to 063aa87 Compare August 15, 2023 18:58
@ax3l
Copy link
Member

ax3l commented Aug 15, 2023

@EZoni just FYI, I rebased this on main to include updates from #95

@ax3l ax3l changed the title [WIP] Heat equation tutorial with pyamrex Heat equation tutorial with pyamrex Aug 15, 2023
@ax3l
Copy link
Member

ax3l commented Aug 15, 2023

@EZoni @atmyers @RevathiJambunathan this is also ready for review :)

@ax3l
Copy link
Member

ax3l commented Sep 19, 2023

@EZoni @atmyers @RevathiJambunathan ping :)

@atmyers atmyers merged commit 15210d5 into AMReX-Codes:main Sep 19, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants