Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add misc-misplaced-const check to clang-tidy CI test #3464

Conversation

lucafedeli88
Copy link
Contributor

Summary

This PR adds the misc-misplaced-const check to clang-tidy CI test.
I am not sure if you want to enforce this in AMReX, but I find the constructs it protects against quite misleading.

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@WeiqunZhang
Copy link
Member

Yes, we do want to add this check. I actually have been working on add more checks (including this one). But it will take a while for it to be ready. https://github.com/WeiqunZhang/amrex/blob/more_lint/.clang-tidy#L23

@WeiqunZhang WeiqunZhang merged commit 67b8a5b into AMReX-Codes:development Aug 2, 2023
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants