Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python bindings for AMReX-MPMD #271

Merged
merged 51 commits into from
Apr 30, 2024
Merged

Conversation

siddanib
Copy link
Contributor

This PR is a draft that includes python bindings for Multiple Program Multiple Data (MPMD) feature of AMReX. This feature depends on MPI for the involved C++ executable and mpi4py for the involved python script. The submitted python bindings are based on the latest AMReX_MPMD.H and AMReX_MPMD.cpp.

Bhargav Siddani and others added 26 commits February 1, 2024 11:16
@ax3l ax3l added the enhancement New feature or request label Mar 1, 2024
.gitignore Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
siddanib and others added 2 commits March 3, 2024 17:16
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
@ax3l ax3l requested a review from WeiqunZhang March 21, 2024 13:37
src/Base/MPMD.cpp Outdated Show resolved Hide resolved
@ax3l
Copy link
Member

ax3l commented Apr 4, 2024

From Slack:

Could you please consider this particular branch for testing the previous approach (https://github.com/siddanib/pyamrex/tree/development).
Could you please use this particular case for testing (https://github.com/siddanib/pyamrex/tree/development/tests/test_MPMD/MultiFab_two_way). AMREX_HOME in GNUmakefile needs to be changed.
I installed pyAMReX as follows:

cmake -S . -B build -DAMReX_SPACEDIM="1;2;3" -DpyAMReX_amrex_src=/home/bsiddani/siddanib_github/amrex
cmake --build build -j 8 --target pip_install

For the test case:
I first build the main.cpp file as follows

make -j 10

Then I run the MPMD case as follows

mpirun -np 8 ./main3d.gnu.DEBUG.MPI.ex : -np 4 python main.py

I will submit two clean examples once we figure out this issue. Please let me know if any additional information is needed. Thanks!

Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM! :)

As a follow-up PR, can you add a tests/test_MPMD/test_1/README.rst file that describes the exact steps how to run this test?

@ax3l ax3l enabled auto-merge (squash) April 30, 2024 22:54
@ax3l ax3l disabled auto-merge April 30, 2024 23:34
@ax3l
Copy link
Member

ax3l commented Apr 30, 2024

I have to unbreak the macOS CI separately :)
Just a breaking change in homebrew/pip interaction.

@ax3l ax3l merged commit d75140f into AMReX-Codes:development Apr 30, 2024
18 of 19 checks passed
@siddanib siddanib deleted the develop_pr branch May 8, 2024 19:47
@ax3l ax3l mentioned this pull request May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants