Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated footer #1021

Closed
wants to merge 2 commits into from
Closed

updated footer #1021

wants to merge 2 commits into from

Conversation

Aazib-at-hub
Copy link

@Aazib-at-hub Aazib-at-hub commented Oct 15, 2024 •
edited
Loading

Pull Request Checklist

BEFORE
Screenshot from 2024-10-16 03-15-00
AFTER
Screenshot from 2024-10-16 03-23-40

  • I have added screenshots and videos to show before and after the working of my code.
  • I have ensured that the screen size is set to 100% while making the video.
  • I have synced the latest fork with my local repository and resolved any conflicts.
  • I have mentioned the issue number which I created before making this PR .(format to mention issue number is : fixes #(issue number) )
  • I understand that if any the above conditions are not met , my PR will not be MERGED .

@netlify Netlify
Copy link

netlify bot commented Oct 15, 2024 •
edited
Loading

✅ Deploy Preview for aquamarine-duckanoo-d86f1a ready!

Name Link
🔨 Latest commit cf65717
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-duckanoo-d86f1a/deploys/670ee508c5ca4b0008473730
😎 Deploy Preview https://deploy-preview-1021--aquamarine-duckanoo-d86f1a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hiteashgupta1
Copy link
Collaborator

Mention issue number

@Aazib-at-hub
Copy link
Author

Aazib-at-hub commented Oct 16, 2024 •
edited
Loading

Mention issue number

@hiteashgupta1 #1019

@hiteashgupta1
Copy link
Collaborator

Kindly refork and resync

@hiteashgupta1
Copy link
Collaborator

fixes #1019

@ANSHIKA-26
Copy link
Owner

1.the new footer is way off the color schema we have followed , fix it

ANSHIKA-26
ANSHIKA-26 requested changes Oct 16, 2024
View reviewed changes
updated footer
<i class="fab fa-twitter">
</i>
<span>
@twitteruser
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@user doesnt make any sense , either fix this or remove this from everywhere

updated footer
<head>
<title>
Web Page
</title>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the footer in 1 HTML FILE ? with all the CSS and JS present inline ?

@ANSHIKA-26
Copy link
Owner

fix all these changes and then open another PR , follow checklist and keep us updated on issue comments as to what you are doing

@ANSHIKA-26 ANSHIKA-26 closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ANSHIKA-26 ANSHIKA-26 ANSHIKA-26 requested changes

Assignees
No one assigned
Labels
gssoc-ext hacktoberfest-accepted level 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aazib-at-hub @hiteashgupta1 @ANSHIKA-26