-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #92 - Update dependencies to symfony v7.0 #95
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As can be seen in the composer.json this bundle does not have a dependency on doctrine annotations, so this approach is not correct as the class potentially is not there. The service retrieval and tagging on the lines below should happen in a compiler pass instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look the BreadcrumbLister.php file, you can see dependencia of Doctrine\Common\Annotations\Reader;
When you run the tests with the last version with symfony 6.0, we can look this message
7x: Since symfony/framework-bundle 6.4: The "Doctrine\Common\Annotations\Reader" service alias is deprecated without replacement. It is being referenced by the "APY\BreadcrumbTrailBundle\EventListener\BreadcrumbListener" service.
1x in BundleInitializationTest::testServicesAreRegisteredToContainer from APY\BreadcrumbTrailBundle
1x in BreadcrumbListenerTest::testAnnotations from APY\BreadcrumbTrailBundle\EventListener
1x in BreadcrumbListenerTest::testAttributes from APY\BreadcrumbTrailBundle\EventListener
1x in BreadcrumbListenerTest::testMixingAnnotationsWithAttributesFails from APY\BreadcrumbTrailBundle\EventListener
1x in BreadcrumbListenerTest::testInvokableController from APY\BreadcrumbTrailBundle\EventListener
...