Feature/235 get flow partitionings

[salamonpavel]

Introduces GET endpoint for retrieval of partitionings of a given flow
Closes #235

Release notes:

• Introduces GET endpoint for retrieval of partitionings of a given flow

[salamonpavel]

Release notes:

• Introduces GET endpoint for retrieval of partitionings of a given flow

[github-actions]

JaCoCo model module code coverage report - scala 2.13.11

Overall Project	63.64%	🍏

There is no coverage information present for the Files changed

[github-actions]

JaCoCo agent module code coverage report - scala 2.13.11

Overall Project	84.63%	🍏

There is no coverage information present for the Files changed

[github-actions]

JaCoCo reader module code coverage report - scala 2.13.11

Overall Project	100%	🍏

There is no coverage information present for the Files changed

[github-actions]

JaCoCo server module code coverage report - scala 2.13.11

Overall Project	75.29% -7.88%	🍏
Files changed	62.57%	❌

File	Coverage
PartitioningRepositoryImpl.scala	100%	🍏
PartitioningServiceImpl.scala	100%	🍏
PartitioningControllerImpl.scala	89.62%	🍏
GetFlowPartitionings.scala	70.48%	❌

[benedeki]

Suggested change

	WITH limited_partitionings AS (
	SELECT P.id_partitioning
	FROM flows.partitioning_to_flow PF
	JOIN runs.partitionings P ON PF.fk_partitioning = P.id_partitioning
	WHERE PF.fk_flow = i_flow_id
	ORDER BY P.created_at DESC, P.id_partitioning
	LIMIT i_limit OFFSET i_offset
	)
	SELECT
	11 AS status,
	'OK' AS status_text,
	P.id_partitioning AS id,
	P.partitioning,
	P.created_by AS author,
	_has_more AS has_more
	FROM
	runs.partitionings P
	WHERE
	P.id_partitioning IN (SELECT LP.id_partitioning FROM limited_partitionings LP)
	ORDER BY
	P.created_at DESC,
	P.id_partitioning;
	SELECT
	11 AS status,
	'OK' AS status_text,
	P.id_partitioning,
	P.partitioning,
	P.created_by,
	has_more
	FROM
	runs.partitionings P INNER JOIN
	flows.partitioning_to_flow PF ON PF.fk_partitioning = P.id_partitioning
	WHERE
	PF.fk_flow = i_flow
	ORDER BY
	P.id_partitioning,
	P.created_at DESC
	LIMIT i_limit OFFSET i_offset;

Several things:

• You don't need the WITH here. Generally the order of approaches to use:
  • use JOIN
  • use subquery - there are cases where this can be better then JOIN, but we don't have that much data yet to run a meaningful comparison
  • use WITH
  • use temporary tables
• in the RETURN QUERY statement it's not required the output column names to be the same as the OUT ones. Only the position matters.
• I switched the order of ORDER BY columns, reasons described here

[salamonpavel]

ok changed

[benedeki]

Same comment as here. Do we return an error?

[salamonpavel]

ok changed

[lsulak]

do we also want to care whether a given partitioning was primary for the given flow?

[benedeki]

Little value now, and adds a table to the JOIN.
IMHO not worth it.
Btw, we could add the main flow id to partitioning table (for easier search and one less index).

[lsulak]

Review finished, apart from 1 q from me and 1 note from David it looks good

[benedeki]

Suggested change

	IF NOT FOUND THEN
	status := 12;
	status_text := 'OK with no partitionings found';
	RETURN NEXT;
	END IF;