get partitioning #275
Merged
get partitioning #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salamonpavel
added
the
work in progress
|
Release notes:
|
JaCoCo model module code coverage report - scala 2.13.11
|
JaCoCo agent module code coverage report - scala 2.13.11
|
JaCoCo reader module code coverage report - scala 2.13.11
|
JaCoCo server module code coverage report - scala 2.13.11
|
salamonpavel
removed
the
work in progress
salamonpavel
requested review from
benedeki,
lsulak,
TebaleloS,
Zejnilovic and
dk1844
as code owners
benedeki
reviewed
Sep 27, 2024
.github/workflows/jacoco_report.yml
Outdated
| @@ -63,7 +63,7 @@ jobs: | |||
| - name: Add coverage to PR (model) | |||
| if: steps.jacocorun.outcome == 'success' | |||
| id: jacoco-model | |||
| uses: madrapps/jacoco-report@v1.6.1 | |||
| uses: madrapps/jacoco-report@v1.7.1 | |||
There was a problem hiding this comment.
Interesting, I though this was done in earlier of your PRs 😄
There was a problem hiding this comment.
yeah I have done it also here to see "more correct" numbers whilst working on the draft pr ...
# Conflicts: # server/src/main/scala/za/co/absa/atum/server/Main.scala # server/src/main/scala/za/co/absa/atum/server/api/controller/PartitioningController.scala # server/src/main/scala/za/co/absa/atum/server/api/controller/PartitioningControllerImpl.scala # server/src/main/scala/za/co/absa/atum/server/api/http/Endpoints.scala # server/src/main/scala/za/co/absa/atum/server/api/http/Routes.scala # server/src/main/scala/za/co/absa/atum/server/api/repository/PartitioningRepository.scala # server/src/main/scala/za/co/absa/atum/server/api/repository/PartitioningRepositoryImpl.scala # server/src/main/scala/za/co/absa/atum/server/api/service/PartitioningService.scala # server/src/main/scala/za/co/absa/atum/server/api/service/PartitioningServiceImpl.scala # server/src/test/scala/za/co/absa/atum/server/api/TestData.scala # server/src/test/scala/za/co/absa/atum/server/api/controller/PartitioningControllerUnitTests.scala # server/src/test/scala/za/co/absa/atum/server/api/repository/PartitioningRepositoryUnitTests.scala # server/src/test/scala/za/co/absa/atum/server/api/service/PartitioningServiceUnitTests.scala
benedeki
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #268
Release notes: