Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tapError on secret retrieval #294

Merged
merged 1 commit into from
Oct 17, 2024
Merged

tapError on secret retrieval #294

merged 1 commit into from
Oct 17, 2024

Conversation

salamonpavel
Copy link
Collaborator

@salamonpavel salamonpavel commented Oct 17, 2024 •
edited
Loading

Introduces logging of aws secrets retrieval failures.

@github-actions GitHub Actions
Copy link

JaCoCo model module code coverage report - scala 2.13.11

Overall Project 59.69% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

JaCoCo agent module code coverage report - scala 2.13.11

Overall Project 78.49% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

JaCoCo reader module code coverage report - scala 2.13.11

Overall Project 100% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

JaCoCo server module code coverage report - scala 2.13.11

Overall Project 68.89% 🍏
Files changed 100% 🍏

File Coverage
AwsSecretsProviderImpl.scala 90.48% 🍏

@lsulak lsulak added the no RN No release notes required label Oct 17, 2024
@salamonpavel salamonpavel merged commit 4c9e9a5 into master Oct 17, 2024
10 of 11 checks passed
@salamonpavel salamonpavel deleted the feature/log-credentials-retrieval-error branch October 17, 2024 12:44
@salamonpavel
Copy link
Collaborator Author

Release notes:

  • Introduces logging of aws secrets retrieval failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsulak lsulak lsulak approved these changes

@benedeki benedeki Awaiting requested review from benedeki benedeki is a code owner

@TebaleloS TebaleloS Awaiting requested review from TebaleloS

@Zejnilovic Zejnilovic Awaiting requested review from Zejnilovic Zejnilovic is a code owner

@dk1844 dk1844 Awaiting requested review from dk1844 dk1844 is a code owner

Assignees
No one assigned
Labels
no RN No release notes required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salamonpavel @lsulak