Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ED-4479:Adding sample code for Database Procedures without registration #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vsreeniv
Copy link
Contributor

This is related to video uploaded in Actian Academy.

…on feature. This is related to video uploaded in Actian Academy.
@vsreeniv vsreeniv requested review from clach04 and mianculovici July 25, 2024 17:01
Copy link
Collaborator

@mianculovici mianculovici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clach04
Copy link
Member

clach04 commented Aug 7, 2024

@vsreeniv sorry I somehow missed this! Finally got to see it.

code looks fine, I think there should be a sample procedure. The in progress video https://actian.atlassian.net/browse/ED-4479 mentions this code and specifically mentions Oracle so a single demo with Oracle would be fine.

I also recommend a README.md be placed in the directory database_procedures_without_registering, even if all it has is a list of the files and a short sentence/explanation for each. Ideally, once we have tee live Academy URL we can include that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants