Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] convert to an engine #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] convert to an engine #30

wants to merge 1 commit into from

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Mar 20, 2016

No description provided.

@no-reply
Copy link
Member

Is a Rails engine overkill for this? I'm wondering whether this couldn't just be a Rack app with a route pointing to it?

@jcoyne jcoyne force-pushed the engine branch 8 times, most recently from 6767db5 to 9e549b5 Compare March 21, 2016 21:22
@jcoyne
Convert to an engine
cde2c60 
Also switch testing from Circle to Travis-CI
@scande3
Copy link
Contributor

scande3 commented Mar 22, 2016

I'll try this pull request out by tomorrow.

@no-reply - No experience with a Rack app. What makes the engine overkill exactly?

scande3
scande3 reviewed Mar 23, 2016
View reviewed changes
lib/generators/linked_data_fragments/templates/config/ldf.yml
uri_endpoint: 'http://localhost:3000/{?subject}'
uri_root: 'http://localhost:3000/#dataset'
cache_backend:
provider: 'marmotta'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we are only copying over one config file now. If this is the case, why not have it be the Repository one as it requires no additional running software? We can then provide documentation or samples on how to configure it against a Marmotta, Blazegraph, etc. instance.

@scande3
Copy link
Contributor

scande3 commented Mar 23, 2016

Some other quick notes beyond the comments above from some testing:

  1. Doing http://localhost:3000/ldf/?format=jsonld raises "No writer found using [:jsonld]" . It seems to work for ".nt" and ".ttl" though...
  2. Can the README be changed to include something like the following to make it easier for someone to try it (can expand upon this later):
  • Add the following to you Gemfile: gem 'linked_data_fragments', github: 'ActiveTriples/linked-data-fragments'
  • run the command: bundle install
  • run the command: rails generate linked_data_fragments:install
  • See forthcoming docs for additional configuration options.

Seems to work otherwise but will test it some more tonight. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcoyne @no-reply @scande3