move static assets to /public so the paths work same in dev mode

src/common/__mocks__/core.mock.serviceTypes.js

@@ -2,8 +2,8 @@ export default [
     {
         typeName: 'Atlassian Bamboo',
         baseUrl: 'bamboo',
-        icon: 'services/bamboo/icon.png',
-        logo: 'services/bamboo/logo.png',
+        icon: 'bamboo.png',
+        logo: 'bamboo.png',
         fields: [
             {
                 type: 'url',
@@ -23,8 +23,8 @@ export default [
     {
         typeName: 'BuildBot',
         baseUrl: 'buildbot',
-        icon: 'services/buildbot/icon.png',
-        logo: 'services/buildbot/logo.png',
+        icon: 'buildbot.png',
+        logo: 'buildbot.png',
         fields: [
             { type: 'url', name: 'Server URL, e.g. https://build.webkit.org/' },
             { type: 'username' },
@@ -42,8 +42,8 @@ export default [
     {
         typeName: 'BuildKite',
         baseUrl: 'buildkite',
-        icon: 'services/buildkite/icon.png',
-        logo: 'services/buildkite/logo.svg',
+        icon: 'buildkite.png',
+        logo: 'buildkite.svg',
         fields: [
             {
                 type: 'token',
@@ -62,8 +62,8 @@ export default [
     {
         typeName: 'CCTray XML',
         baseUrl: 'cctray',
-        icon: 'services/cctray/icon.png',
-        logo: 'services/cctray/logo.png',
+        icon: 'cctray.png',
+        logo: 'cctray.png',
         defaultConfig: {
             baseUrl: 'cctray',
             name: '',
@@ -85,8 +85,8 @@ export default [
     {
         typeName: 'GitHub Actions',
         baseUrl: 'github',
-        icon: 'services/github/icon.png',
-        logo: 'services/github/logo.svg',
+        icon: 'github.png',
+        logo: 'github.svg',
         fields: [
             {
                 type: 'url',
@@ -109,8 +109,8 @@ export default [
     {
         typeName: 'Jenkins',
         baseUrl: 'jenkins',
-        icon: 'services/jenkins/icon.png',
-        logo: 'services/jenkins/logo.png',
+        icon: 'jenkins.png',
+        logo: 'jenkins.png',
         fields: [
             {
                 type: 'url',
@@ -131,8 +131,8 @@ export default [
     {
         typeName: 'TeamCity',
         baseUrl: 'teamcity',
-        icon: 'services/teamcity/icon.png',
-        logo: 'services/teamcity/logo.png',
+        icon: 'teamcity.png',
+        logo: 'teamcity.png',
         fields: [
             { type: 'url', name: 'Server URL, e.g. http://teamcity.jetbrains.com/' },
             { type: 'username' },

src/options/components/sidebar.tsx

@@ -11,7 +11,7 @@ export default ({ service, view }: { service?: CIServiceSettings; view?: string
 
     const getIconFor = (baseUrl): string => {
         const item = serviceTypes.find(serviceType => serviceType.baseUrl === baseUrl);
-        return item ? `/${item.icon}` : '';
+        return item ? `/icons/${item.icon}` : '';
     };
     // TODO: sortable
     return (

src/options/pages/add/components/serviceThumbnails.tsx

@@ -30,7 +30,10 @@ export default ({
                     }}
                 >
                     <div className="thumbnail-image">
-                        <img src={`/${serviceType.logo}`} alt={serviceType.typeName} />
+                        <img
+                            src={`/logos/${serviceType.logo}`}
+                            alt={serviceType.typeName}
+                        />
                     </div>
                     <div className="caption">{serviceType.typeName}</div>
                 </a>

src/service-worker/notification.test.ts

@@ -55,15 +55,17 @@ describe('show', () => {
     });
 
     it('adds iconUrl', async () => {
-        mockChrome.runtime.getURL.mockImplementation(icon => `https://google.com/${icon}`);
+        mockChrome.runtime.getURL.mockImplementation(
+            icon => `chrome-extension://BR${icon}`,
+        );
 
         await notification.show(testInfo);
 
-        expect(mockChrome.runtime.getURL).toBeCalledWith(`services/baseUrl/icon.png`);
+        expect(mockChrome.runtime.getURL).toBeCalledWith(`/icons/baseUrl.png`);
         expect(mockChrome.notifications.create).toBeCalledWith(
             testInfo.id,
             expect.objectContaining({
-                iconUrl: `https://google.com/services/baseUrl/icon.png`,
+                iconUrl: `chrome-extension://BR/icons/baseUrl.png`,
             }),
         );
     });

src/service-worker/notification.ts

@@ -47,7 +47,7 @@ async function getIcon(info: NotificationInfo) {
     const service = await serviceConfig.getItem(info.serviceName);
     if (!service) throw new Error(`Service ${info.serviceName} not found`);
     const serviceType = service.baseUrl;
-    const icon = chrome.runtime.getURL(`services/${serviceType}/icon.png`);
+    const icon = chrome.runtime.getURL(`/icons/${serviceType}.png`);
     return icon;
 }
 

src/services/bamboo/bamboo.ts

@@ -69,8 +69,8 @@ export default {
     getDefinition: (): CIServiceDefinition => ({
         typeName: 'Atlassian Bamboo',
         baseUrl: 'bamboo',
-        icon: 'services/bamboo/icon.png',
-        logo: 'services/bamboo/logo.png',
+        icon: 'bamboo.png',
+        logo: 'bamboo.png',
         fields: [
             {
                 type: 'url',

src/services/buildbot/buildbot.ts

@@ -53,8 +53,8 @@ export default {
     getDefinition: () => ({
         typeName: 'BuildBot',
         baseUrl: 'buildbot',
-        icon: 'services/buildbot/icon.png',
-        logo: 'services/buildbot/logo.png',
+        icon: 'buildbot.png',
+        logo: 'buildbot.png',
         fields: [
             { type: 'url', name: 'Server URL, e.g. https://build.webkit.org/' },
             { type: 'username' },

src/services/buildkite/buildkite.ts

@@ -109,8 +109,8 @@ export default {
     getDefinition: (): CIServiceDefinition => ({
         typeName: 'BuildKite',
         baseUrl: 'buildkite',
-        icon: 'services/buildkite/icon.png',
-        logo: 'services/buildkite/logo.svg',
+        icon: 'buildkite.png',
+        logo: 'buildkite.svg',
         fields: [
             {
                 type: 'token',

src/services/cctray/cctray.ts

@@ -30,8 +30,8 @@ export default {
     getDefinition: (): CIServiceDefinition => ({
         typeName: 'CCTray XML',
         baseUrl: 'cctray',
-        icon: 'services/cctray/icon.png',
-        logo: 'services/cctray/logo.png',
+        icon: 'cctray.png',
+        logo: 'cctray.png',
         defaultConfig: {
             baseUrl: 'cctray',
             name: '',

src/services/github/github.ts

@@ -50,8 +50,8 @@ export default {
     getDefinition: (): CIServiceDefinition => ({
         typeName: 'GitHub Actions',
         baseUrl: 'github',
-        icon: 'services/github/icon.png',
-        logo: 'services/github/logo.svg',
+        icon: 'github.png',
+        logo: 'github.svg',
         fields: [
             {
                 type: 'url',

src/services/jenkins/jenkins.ts

@@ -107,8 +107,8 @@ export default {
         return {
             typeName: 'Jenkins',
             baseUrl: 'jenkins',
-            icon: 'services/jenkins/icon.png',
-            logo: 'services/jenkins/logo.png',
+            icon: 'jenkins.png',
+            logo: 'jenkins.png',
             fields: [
                 {
                     type: 'url',

src/services/teamcity/teamcity.ts

@@ -66,8 +66,8 @@ export default {
     getDefinition: (): CIServiceDefinition => ({
         typeName: 'TeamCity',
         baseUrl: 'teamcity',
-        icon: 'services/teamcity/icon.png',
-        logo: 'services/teamcity/logo.png',
+        icon: 'teamcity.png',
+        logo: 'teamcity.png',
         fields: [
             { type: 'url', name: 'Server URL, e.g. http://teamcity.jetbrains.com/' },
             { type: 'username' },

src/services/travis/travis.ts

@@ -64,8 +64,8 @@ export default {
     getDefinition: (): CIServiceDefinition => ({
         typeName: 'Travis',
         baseUrl: 'travis',
-        icon: 'services/travis/icon.png',
-        logo: 'services/travis/logo.png',
+        icon: 'travis.png',
+        logo: 'travis.png',
         fields: [
             {
                 type: 'url',

vite.config.mts

@@ -15,14 +15,7 @@ export default defineConfig({
         react(),
         copy({
             flatten: false,
-            targets: [
-                {
-                    src: ['src/services/**/*.png', 'src/services/**/*.svg'],
-                    dest: 'dist/build/',
-                },
-                { src: 'img/*', dest: 'dist/build/img/' },
-                { src: 'manifest.json', dest: 'dist/build/' },
-            ],
+            targets: [{ src: 'manifest.json', dest: 'dist/build/' }],
         }),
         tsconfigPaths(),
         zipPack({
@@ -33,7 +26,7 @@ export default defineConfig({
     ],
     build: {
         assetsInlineLimit: 0,
-        emptyOutDir: false,
+        emptyOutDir: true,
         sourcemap: true,
         minify: true,
         rollupOptions: {
@@ -48,7 +41,7 @@ export default defineConfig({
                 format: 'es',
                 entryFileNames: '[name].js',
                 chunkFileNames: '[name]-chunk.js',
-                assetFileNames: '[name].[ext]',
+                assetFileNames: 'assets/[name].[ext]',
             },
         },
     },