Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax in escaping comment #145

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Fix syntax in escaping comment #145

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bae4df
Fix syntax in escaping comment
jlnarvaez Apr 27, 2023
4ba45f8
Merge branch 'main' into patch-3
jeff-matthews Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pages/development/security/cross-site-scripting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,8 @@ To check your .phtml template for XSS vulnerabilities, use the _Magento2.Securit
This sniff finds all _echo_ calls in PHTML-templates and determines if the output is properly escaped.
It covers the following cases:

- `/_ @noEscape _/` before output. Output does not require escaping. Test is green.
- `/_ @escapeNotVerified _/` before output. Output escaping is not checked and should be verified. Test is green.
- `/* @noEscape */` before output. Output does not require escaping. Test is green.
- `/* @escapeNotVerified */` before output. Output escaping is not checked and should be verified. Test is green.
- Methods which contain "html" in their names (for example echo $object->{suffix}Html{postfix}()). Data is ready for the HTML output. Test is green.
- AbstractBlock methods `escapeHtml`, `escapeHtmlAttr`, `escapeUrl`, `escapeJs` are allowed. Test is green.
- Type casting and php function `count()` are allowed (for example `echo (int)$var`, `(bool)$var`, `count($var)`). Test is green.
Expand Down