Fixed xml modify-image-library-permissions.md #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-matthews
added
the
technical
jeff-matthews
approved these changes
Nov 30, 2023
jeff-matthews
requested changes
Nov 30, 2023
There was a problem hiding this comment.
Thanks @aartse. It's consistent with other code samples in the PHP guide.
Just a couple of things before I can approve an merge:
- Please sign the Adobe CLA (see "checks" section at bottom of PR)
- You'll need to fix the ,md linting errors reported here (I think you just need to fix the indentation of the code sample to align with the opening and closing code fences)
jeff-matthews
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) Fixes xml modify-image-library-permissions.md
Affected pages
https://developer.adobe.com/commerce/php/tutorials/backend/modify-image-library-permissions/