Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACPT-1493: Reset via reflection for ApplicationServer #286

Merged
merged 6 commits into from
Oct 3, 2024

Conversation

JacobBrownAustin
Copy link

Purpose of this pull request

It seems like this feature won't be added until 2.4.8, so the documentation shouldn't be updated until then.
Added documentation for new feature that allows resetting via reflection for ApplicationServer.

Affected pages

https://developer.adobe.com/commerce/php/development/components/app-server/

  • ...

Links to Magento Open Source code

https://github.com/magento-commerce/magento2ce/pull/8717

  • ...

Added documentation for new feature that allows resetting via reflection
for ApplicationServer.
@jeff-matthews jeff-matthews changed the base branch from main to 2.4.8-develop July 15, 2024 14:05
@jeff-matthews jeff-matthews changed the base branch from 2.4.8-develop to main July 15, 2024 14:05
@jeff-matthews jeff-matthews added major-update Significant original updates to existing content internal Differentiates work between external and internal contributors 2.4.8 labels Jul 15, 2024
@jeff-matthews
Copy link
Contributor

@JacobBrownAustin, can we change the base branch to 2.4.8-develop and process or is there a chance that this will be available in an earlier release?

@JacobBrownAustin
Copy link
Author

@JacobBrownAustin, can we change the base branch to 2.4.8-develop and process or is there a chance that this will be available in an earlier release?

There was talk about possibly releasing it before 2.4.8 in a 2.4.7-p? release, but it probably won't happen because people only want to add security fixes or bug fixes. But maybe it will. I guess it depends on how necessary this functionality is versus the goal of adding no new functionality in patch releases.

I think rebasing it to 2.4.8-develop would make more sense for now as that is more likely that it won't get released until 2.4.8.

@jeff-matthews jeff-matthews changed the base branch from main to 2.4.8-develop August 14, 2024 21:06
@jeff-matthews
Copy link
Contributor

@jhadobe, please work with Jacob and Misha to confirm whether this will be available in 2.4.8-beta1. If so, please process and merge into the 2.4.8-develop branch. Don't forget to add a note indicating that it's 2.4.8-beta (no number designation required).

src/pages/development/components/app-server.md Outdated Show resolved Hide resolved
src/pages/development/components/app-server.md Outdated Show resolved Hide resolved
src/pages/development/components/app-server.md Outdated Show resolved Hide resolved
src/pages/development/components/app-server.md Outdated Show resolved Hide resolved
src/pages/development/components/app-server.md Outdated Show resolved Hide resolved
src/pages/development/components/app-server.md Outdated Show resolved Hide resolved
jhadobe and others added 2 commits September 24, 2024 10:26
Co-authored-by: Jared Hoover <98363870+jhadobe@users.noreply.github.com>
jeff-matthews and others added 2 commits October 3, 2024 12:02
Co-authored-by: Jared Hoover <98363870+jhadobe@users.noreply.github.com>
@jeff-matthews jeff-matthews dismissed jhadobe’s stale review October 3, 2024 17:03

Accepted Jared's suggestions

@jeff-matthews jeff-matthews merged commit 1cefae1 into AdobeDocs:2.4.8-develop Oct 3, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.4.8 internal Differentiates work between external and internal contributors major-update Significant original updates to existing content
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

3 participants