Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2.4.6-2.4.7.md about ChangeLogBatchWalkerInterface #308

Closed
wants to merge 1 commit into from

Conversation

rbayet
Copy link

@rbayet rbayet commented Aug 23, 2024

\Magento\Framework\Mview\View\ChangeLogBatchWalkerInterface was renamed along with \Magento\Framework\Mview\View\ChangeLogBatchWalker which will break compatibility of third-party modules implementing their own log batch walker.

Purpose of this pull request

This pull request (PR) addresses the renaming of interface \Magento\Framework\Mview\View\ChangeLogBatchWalkerInterface into \Magento\Framework\Mview\View\ChangelogBatchWalkerInterface which will prevent third party modules or project implementing the interface to migrate properly from 2.4.6 to 2.4.7

  • phpstan will raise an error
  • setup:di:compile will fail

I didn't know if it was preferable to have the old or the new name in the left column.

Affected pages

Links to Magento Open Source code

\Magento\Framework\Mview\View\ChangeLogBatchWalkerInterface
was renamed along with \Magento\Framework\Mview\View\ChangeLogBatchWalker which will break compatibility of third-party modules implementing their own log batch walker.
@jeff-matthews jeff-matthews added the technical Updates to the code or processes that alter the technical content of the doc label Aug 23, 2024
@dshevtsov
Copy link
Contributor

dshevtsov commented Aug 23, 2024

@rbayet thank you for your contribution. I created an internal ticket COMDOX-1050 to investigate the missing backward incompatible changes. I am closing this pull request since we do not accept pull requests to these files.

@dshevtsov dshevtsov closed this Aug 23, 2024
dshevtsov added a commit to commerce-docs/commerce-php that referenced this pull request Aug 28, 2024
dshevtsov added a commit to commerce-docs/commerce-php that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical Updates to the code or processes that alter the technical content of the doc
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants