Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare implementation for DPT (Depth of Water) messages #132

Merged
merged 27 commits into from
Oct 12, 2024

Conversation

trkohler
Copy link
Contributor

@trkohler trkohler commented Aug 25, 2024

connect: #54

@elpiel
Copy link
Member

elpiel commented Aug 26, 2024

I see you made a typo, this is why you get a name conflict.
The type of the sentence is DPT, instead of DBT. If you use DPT there will be no conflict.

Cargo.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/parse.rs Outdated Show resolved Hide resolved
@trkohler trkohler changed the title Prepare implementation for DBT (Depth of Water) messages Prepare implementation for DPT (Depth of Water) messages Aug 26, 2024
src/sentences/dpt.rs Outdated Show resolved Hide resolved
src/sentences/dpt.rs Outdated Show resolved Hide resolved
src/sentences/dpt.rs Outdated Show resolved Hide resolved
src/sentences/dpt.rs Outdated Show resolved Hide resolved
src/sentences/dpt.rs Outdated Show resolved Hide resolved
src/sentences/dpt.rs Outdated Show resolved Hide resolved
src/sentences/dpt.rs Outdated Show resolved Hide resolved
src/sentences/dpt.rs Outdated Show resolved Hide resolved
@trkohler
Copy link
Contributor Author

tests currently not passing because I need to clarify how to handle those cases: $SDDPT,2.4,,*53 and $SDDPT,15.2,0.5,*6C (with trailing commas)

trkohler and others added 7 commits August 31, 2024 12:02
Co-authored-by: Lachezar Lechev <8925621+elpiel@users.noreply.github.com>
Co-authored-by: Lachezar Lechev <8925621+elpiel@users.noreply.github.com>
Co-authored-by: Lachezar Lechev <8925621+elpiel@users.noreply.github.com>
Co-authored-by: Lachezar Lechev <8925621+elpiel@users.noreply.github.com>
src/sentences/dpt.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

Attention: Patch coverage is 82.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.91%. Comparing base (2e14541) to head (864ddde).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
src/sentences/dpt.rs 83.33% 5 Missing ⚠️
src/parser.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   78.89%   78.91%   +0.02%     
==========================================
  Files          37       38       +1     
  Lines        1388     1423      +35     
==========================================
+ Hits         1095     1123      +28     
- Misses        293      300       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trkohler trkohler marked this pull request as ready for review August 31, 2024 20:14
@trkohler trkohler requested a review from elpiel October 7, 2024 09:27
@elpiel elpiel added the Hacktoberfest Issues suitable for Hacktoberfest label Oct 11, 2024
Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution

src/sentences/dpt.rs Outdated Show resolved Hide resolved
@elpiel elpiel merged commit 874a36f into AeroRust:main Oct 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Issues suitable for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants