-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Render to nmea #137
WIP Render to nmea #137
Conversation
I would suggest to call the feature "display" and for you to check out the Let me know what you think. Let's start with 1 or 2 *Data structs and see how it looks |
@elpiel I ended up not using the library since my microcontroller is too weak and needs much optimized algorithm, closing this PR, would be happy for anyone to catch up on this |
@k-bx what do you mean by "much more optimized"? |
@elpiel I mean not working with strings, operating directly on Vec, not parsing NMEA sentences fully but doing ad-hoc logic with a subset of bytes. |
The proposal to add API to rust stdlib to convert integer directly from bytes was accepted: rust-lang/libs-team#469 . When new API was added I suppose we can drop conversation to utf-8 before parsing nmea sentences and work directly with bytes. |
This is great @Dushistov ! I will create an issue for working on printing and generating the string representation of the sentences. I think we could start with an experimental feature first, even if it's not finished nor optimised for beginning. |
This is a dirty WIP that's more of an idea beginning rather than a complete implementation. Most likely to be closed and re-imagined.
Related to #100