Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parsing BWW messages #86

Merged
merged 4 commits into from
Apr 27, 2023
Merged

Added parsing BWW messages #86

merged 4 commits into from
Apr 27, 2023

Conversation

taavit
Copy link

@taavit taavit commented Apr 8, 2023

Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me, only 2 small requested changes.
Thank you once again for your PR!

src/sentences/bww.rs Outdated Show resolved Hide resolved
src/sentences/bww.rs Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Patch coverage: 81.57% and project coverage change: +0.61 🎉

Comparison is base (b203556) 79.60% compared to head (75c5c1d) 80.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   79.60%   80.22%   +0.61%     
==========================================
  Files          30       31       +1     
  Lines        1123     1153      +30     
==========================================
+ Hits          894      925      +31     
+ Misses        229      228       -1     
Impacted Files Coverage Δ
src/error.rs 5.26% <0.00%> (-0.80%) ⬇️
src/parser.rs 79.13% <0.00%> (+1.82%) ⬆️
src/sentences/mod.rs 0.00% <ø> (ø)
src/parse.rs 72.61% <100.00%> (+0.66%) ⬆️
src/sentences/bww.rs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@elpiel elpiel merged commit d8f668b into AeroRust:main Apr 27, 2023
@taavit taavit deleted the bww-message branch April 27, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants