Merge pull request #25 from 1415003719/v5

fix(tracking): fix get tracking
AfterShip · Sep 18, 2021 · ea1ccd0 · ea1ccd0
2 parents 76dc157 + aacf185
commit ea1ccd0
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/Aftership-API/src/Tracking.cs b/Aftership-API/src/Tracking.cs
@@ -16,6 +16,7 @@ internal static bool IsNullOrEmpty(this JToken token)
                    (token.Type == JTokenType.Array && !token.HasValues) ||
                    (token.Type == JTokenType.Object && !token.HasValues) ||
                    (token.Type == JTokenType.String && token.ToString() == String.Empty) ||
+                   (token.Type == JTokenType.Float && !token.HasValues) ||
                    (token.Type == JTokenType.Null);
         }
     }
@@ -337,7 +338,7 @@ public Tracking(JObject trackingJSON)
             _orderDate = trackingJSON["order_date"].IsNullOrEmpty() ? null : (String)trackingJSON["order_date"];
             _shipmentPickupDate = trackingJSON["shipment_pickup_date"].IsNullOrEmpty() ? null : (String)trackingJSON["shipment_pickup_date"];
             _shipmentDeliveryDate = trackingJSON["shipment_delivery_date"].IsNullOrEmpty() ? null : (String)trackingJSON["shipment_delivery_date"];
-            _shipmentWeight = trackingJSON["shipment_weight"].IsNullOrEmpty() ? null : (float)trackingJSON["shipment_weight"];
+            _shipmentWeight = trackingJSON["shipment_weight"].IsNullOrEmpty() ? float.NaN : (float)trackingJSON["shipment_weight"];
             _shipmentWeightUnit = trackingJSON["shipment_weight_unit"].IsNullOrEmpty() ? null : (String)trackingJSON["shipment_weight_unit"];
             _lastMileTrackingSupported = trackingJSON["last_mile_tracking_supported"].IsNullOrEmpty() ? false : (Boolean)trackingJSON["last_mile_tracking_supported"];
             _language = trackingJSON["language"].IsNullOrEmpty() ? null : (String)trackingJSON["language"];