Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor parseExpr to allow to use the priority precedence #102

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Sep 25, 2024

This also closes #101

@git-hulk git-hulk force-pushed the refactor/allow-to-use-precedence branch from fec4808 to a82cf05 Compare September 25, 2024 14:00
@git-hulk git-hulk marked this pull request as ready for review September 25, 2024 14:29
@coveralls
Copy link

coveralls commented Sep 25, 2024

Pull Request Test Coverage Report for Build 11046163100

Details

  • 217 of 285 (76.14%) changed or added relevant lines in 7 files are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 59.631%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/ast_visitor.go 6 8 75.0%
parser/parser_table.go 9 12 75.0%
parser/parser_view.go 12 16 75.0%
parser/parser_query.go 24 39 61.54%
parser/parser_column.go 103 123 83.74%
parser/ast.go 58 82 70.73%
Files with Coverage Reduction New Missed Lines %
parser/parser_column.go 4 67.25%
parser/ast.go 9 55.76%
Totals Coverage Status
Change from base Build 10935801786: 0.1%
Covered Lines: 6241
Relevant Lines: 10466

💛 - Coveralls

@git-hulk git-hulk merged commit 675fd43 into AfterShip:master Sep 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to resolve the where condition
3 participants