Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cover local copy in restore integration test #231

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmitry-potepalov
Copy link
Contributor

Run the restore integration suite both with direct and local copy.

Run the restore integration suite both with direct and local copy.
@dmitry-potepalov dmitry-potepalov force-pushed the dmitry-potepalov/clickhouse/integration-test-for-restore-object-storage-files branch from 13eb453 to 8fba8c4 Compare August 28, 2024 16:13
@dmitry-potepalov dmitry-potepalov marked this pull request as ready for review August 28, 2024 16:17
@dmitry-potepalov dmitry-potepalov requested a review from a team August 28, 2024 16:17
@aris-aiven
Copy link
Contributor

Didn't get to it today, reviewing tomorrow.

Copy link
Contributor

@kmichel-aiven kmichel-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add combinatorial explosion of parameters of the entire backup/restore integration tests.

Instead, the two copy variants should be tested by directly testing ThreadSafeRohmuStorage.copy_items_from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants