Skip to content

Commit

Permalink
fix: fixed various stuff that were blocking a new out of the box inst…
Browse files Browse the repository at this point in the history
…allation only using the `GNUmakefile`

fixed errors that I've encountered by cloning the project from scratch in a new folder and using the `GNUmakefile` to set it up and running.
  • Loading branch information
eliax1996 committed Nov 24, 2023
1 parent 190f1af commit eb9ee31
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
6 changes: 3 additions & 3 deletions GNUmakefile
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,9 @@ cleanest: cleaner
requirements: export CUSTOM_COMPILE_COMMAND='make requirements'
requirements:
pip install --upgrade pip setuptools pip-tools
cd requirements && pip-compile --upgrade --resolver=backtracking requirements.in
cd requirements && pip-compile --upgrade --resolver=backtracking requirements-dev.in
cd requirements && pip-compile --upgrade --resolver=backtracking requirements-typing.in
pip-compile --upgrade --resolver=backtracking requirements/requirements.in -o requirements/requirements.txt
pip-compile --upgrade --resolver=backtracking requirements/requirements-dev.in -o requirements/requirements-dev.txt
pip-compile --upgrade --resolver=backtracking requirements/requirements-typing.in -o requirements/requirements-typing.txt

.PHONY: schema
schema: against := origin/main
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/utils/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def from_dict(data: dict) -> "ZKConfig":
@dataclass(frozen=True)
class KafkaDescription:
version: str
kafka_tgz: str
kafka_tgz: Path
install_dir: Path
download_url: str
protocol_version: str
Expand Down
1 change: 1 addition & 0 deletions tests/integration/utils/kafka_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ def maybe_download_kafka(kafka_description: KafkaDescription) -> None:
if not os.path.exists(kafka_description.install_dir):
log.info("Downloading Kafka '%s'", kafka_description.download_url)
download = requests.get(kafka_description.download_url, stream=True)
kafka_description.kafka_tgz.parent.mkdir(parents=True, exist_ok=True)
with open(kafka_description.kafka_tgz, "wb") as fd:
for chunk in download.iter_content(chunk_size=None):
fd.write(chunk)
Expand Down

0 comments on commit eb9ee31

Please sign in to comment.