fix: inconsistent schema during message produce #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
ca65ddd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5a76e9b1.karapace.pages.dev |
| Branch Preview URL: | https://eliax1996-fix-inconsistent-s.karapace.pages.dev |
eliax1996
commented
Jun 23, 2023
eliax1996
force-pushed
the
eliax1996/fix-inconsistent-schema-publish
branch
2 times, most recently
from
4f0ad54
to
66c0057
Compare
eliax1996
force-pushed
the
eliax1996/fix-inconsistent-schema-publish
branch
4 times, most recently
from
c160c44
to
bcda64b
Compare
aiven-anton
reviewed
Jun 26, 2023
eliax1996
force-pushed
the
eliax1996/fix-inconsistent-schema-publish
branch
from
31178d7
to
12085a3
Compare
eliax1996
force-pushed
the
eliax1996/fix-inconsistent-schema-publish
branch
from
12085a3
to
a25b2c2
Compare
aiven-anton
reviewed
Jun 26, 2023
eliax1996
force-pushed
the
eliax1996/fix-inconsistent-schema-publish
branch
from
f3957c0
to
b9983c5
Compare
aiven-anton
reviewed
Jun 26, 2023
eliax1996
force-pushed
the
eliax1996/fix-inconsistent-schema-publish
branch
3 times, most recently
from
0e5db50
to
4b5ed0c
Compare
eliax1996
force-pushed
the
eliax1996/fix-inconsistent-schema-publish
branch
4 times, most recently
from
ead18a2
to
3ec4164
Compare
eliax1996
force-pushed
the
eliax1996/fix-inconsistent-schema-publish
branch
from
8c8a4ad
to
9e79723
Compare
aiven-anton
reviewed
Jun 29, 2023
aiven-anton
reviewed
Jun 29, 2023
aiven-anton
reviewed
Jun 29, 2023
aiven-anton
reviewed
Jun 29, 2023
eliax1996
force-pushed
the
eliax1996/fix-inconsistent-schema-publish
branch
6 times, most recently
from
4eef18f
to
2454161
Compare
eliax1996
force-pushed
the
eliax1996/fix-inconsistent-schema-publish
branch
from
2454161
to
ab3fc15
Compare
aiven-anton
reviewed
Jun 30, 2023
eliax1996
force-pushed
the
eliax1996/fix-inconsistent-schema-publish
branch
4 times, most recently
from
3293378
to
5fa299c
Compare
giuseppelillo
previously requested changes
Jul 3, 2023
eliax1996
force-pushed
the
eliax1996/fix-inconsistent-schema-publish
branch
from
5fa299c
to
8d73b67
Compare
…ossible to produce a message only if the schema sent with the record is registered to the topic.
eliax1996
force-pushed
the
eliax1996/fix-inconsistent-schema-publish
branch
from
8d73b67
to
ca65ddd
Compare
giuseppelillo
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is ment to fix this issue the test where we try this problem is
test_publish_with_schema_id_of_another_subject.The list of subjects bound to a topic has been added to the
/schemas/ids/{id}if the{"includeSubjects": "True"}param are included. This helps the rest proxy in understand if a certain subject when it's required to produce a message providing only theSchemaID, once the REST proxy get the Schema and the list of allowed Subjects it calculate the subject and checks if the required subject it's allowed or not.