Fix typing in protobuf enum and message elements #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliax1996
reviewed
Nov 20, 2023
| from karapace.protobuf.compare_type_lists import compare_type_lists | ||
|
|
||
| if not isinstance(other, MessageElement): | ||
| result.add_modification(Modification.TYPE_ALTER) |
There was a problem hiding this comment.
question, which is the semantics of the compare?
In case of multiple changes, like for e.g. changing type and adding a field to the message do we just return the TYPE_ALTER?
There was a problem hiding this comment.
This line of code should be mostly unreachable as this is invoked from compare_type_lists and there is basically already if statement which checks both self and other of compare call are same type. But for safety it is better to repeat that here instead of adding assert IMHO because this would be right thing to do.
eliax1996
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Fix typing in protobuf enum and message elements