fix: handle ConnectionError in rapu._handle_messages #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiven-anton
previously approved these changes
May 6, 2024
nosahama
reviewed
May 6, 2024
nosahama
previously approved these changes
May 6, 2024
If client connection is broken there is nothing the server can do. Handle the specific case and silence stats and reporting. The aiohttp expects a response object, although this is not and cannot be written to client as the connection is already broken.
jjaakola-aiven
force-pushed
the
jjaakola-aiven-handle-connection-error-in-request-handling
branch
from
2782bd5
to
79fb21a
Compare
nosahama
approved these changes
May 6, 2024
aiven-anton
approved these changes
May 7, 2024
aiven-anton
deleted the
jjaakola-aiven-handle-connection-error-in-request-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
If client connection is broken there is nothing the server can do. Handle the specific case and silence stats and reporting. The aiohttp expects a response object, although this is not and cannot be written to client as the connection is already broken.