-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(graphql): migration to ktor v3 #3844
base: master
Are you sure you want to change the base?
fix(graphql): migration to ktor v3 #3844
Conversation
@AngeloFilaseta, you can target |
K, I'll fix it |
96e0978
to
57f9738
Compare
57f9738
to
1f85072
Compare
Hi @AngeloFilaseta! 👋 |
Quality Gate passedIssues Measures |
@DanySK I discovered the cause of the issue (the timeout). It is not caused by ktor itself. I already changed the code following the migration guide and everything should work within Alchemist. The problem is with another dependency graphql-kotlin, which is still not ready to include ktor v3. So... We wait or what? |
Well, I'd say we wait. Set a timer, and let's check back in a month. |
There are new developments. The |
you forgot the link :) |
Fixed, I should put 1 euro in the virtual wallet for what I thought |
EmbeddedServer
now encapsulatesApplicationEngine
instead of being a subclass.Sorry for the other PR, it defaulted to master and I didn't notice.