Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql): migration to ktor v3 #3844

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AngeloFilaseta
Copy link
Contributor

EmbeddedServer now encapsulates ApplicationEngine instead of being a subclass.

Sorry for the other PR, it defaulted to master and I didn't notice.

@DanySK
Copy link
Member

DanySK commented Oct 18, 2024

@AngeloFilaseta, you can target master directly. Renovate will auto-close its PR once this one is merged.

@DanySK DanySK changed the base branch from renovate/major-3-ktor-monorepo to master October 18, 2024 14:09
@AngeloFilaseta
Copy link
Contributor Author

K, I'll fix it

@DanySK DanySK force-pushed the fix/renovate/major-3-ktor-monorepo branch 9 times, most recently from 96e0978 to 57f9738 Compare October 20, 2024 08:53
@DanySK DanySK force-pushed the fix/renovate/major-3-ktor-monorepo branch from 57f9738 to 1f85072 Compare October 20, 2024 09:00
Copy link
Contributor

mergify bot commented Oct 20, 2024

Hi @AngeloFilaseta! 👋
This pull request has conflicts 😖
Could you fix it? 🔧
Thank you! 🙏

Copy link

sonarcloud bot commented Oct 21, 2024

@AngeloFilaseta
Copy link
Contributor Author

@DanySK I discovered the cause of the issue (the timeout). It is not caused by ktor itself. I already changed the code following the migration guide and everything should work within Alchemist. The problem is with another dependency graphql-kotlin, which is still not ready to include ktor v3.
For now, the GraphQL server silently fails with java.lang.NoClassDefFoundError: io/ktor/server/routing/RoutingKt since it probably expect to find ktor 2 at runtime, but some package structure changed.
Probably, once this PR gets included in the new version of the library, everything will work as expected.

So... We wait or what?

@DanySK
Copy link
Member

DanySK commented Nov 4, 2024

Well, I'd say we wait. Set a timer, and let's check back in a month.

@AngeloFilaseta
Copy link
Contributor Author

AngeloFilaseta commented Nov 13, 2024

There are new developments. The graphql-kotlin project now supports Kotlin 2.
Now this is the PR that needs to be merged. Once they fix it, I'll try to integrate the new version in Alchemist.

@DanySK
Copy link
Member

DanySK commented Nov 13, 2024

you forgot the link :)

@AngeloFilaseta
Copy link
Contributor Author

Fixed, I should put 1 euro in the virtual wallet for what I thought

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants