[Fix] change get_blocks range to closed interval

[xG0Ian]

Motivation

Close issue: #3387

We say GET /testnet/blocks?start={start_height}&end={end_height} Returns the blocks for the given block range ( api doc )

the given block range was not described clearly enough.

/testnet/blocks returns the blocks of from start_height to end_height - 1. But I think it should return from start_height to end_height with closed interval which is more friendly with human intuition, cuz we always use current block height as end_height, easily misunderstood if we need give it current block height + 1.

Test Plan

change

snarkOS/node/rest/src/routes.rs

Line 140 in 0cc6fe3

let blocks = cfg_into_iter!((start_height..end_height))

to

let blocks = cfg_into_iter!((start_height..=end_height)) 

[raychu86]

We are following the inclusive start and exclusive end standard that is present in many blockchain and non-blockchain APIs.

The API documentation could definitely be more clear, however changing this standard will have a lot of downstream effects. This seems like an innocent change, but will break explorers, wallets, services, etc.

[xG0Ian]

got it, so we need to make the documentation clearer.