Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-25854 New docker build action #807

Conversation

wojciech-piotrowiak
Copy link
Contributor

@wojciech-piotrowiak wojciech-piotrowiak commented Nov 5, 2024

Checklist

  • Jira Reference (also in PR title):
  • README updated after adding/changing behaviour of an action
  • Proposed version increment for release:
    • Patch (bugfix)
    • Minor (new feature)
    • Major (breaking changes)
  • External PR link where changes has been tested:

Description

We faced issue where one token should be used to pull docker images during the build and other one with write permission should be used to push.
Similar approach is used in hxpr: https://github.com/HylandSoftware/hxpr/blob/master/.github/workflows/continuous_integration.yaml#L197
https://github.com/HylandSoftware/hxpr/blob/master/.github/workflows/continuous_integration.yaml#L217

New action does not require keepin backward compability and also forces users to provide ghcr username which is crucial as we want to avoid using ${{ github.actor }}

@wojciech-piotrowiak wojciech-piotrowiak self-assigned this Nov 5, 2024
@wojciech-piotrowiak wojciech-piotrowiak changed the title AAE-25854 New token inputs for pull and push AAE-25854 New docker build action Nov 8, 2024
@wojciech-piotrowiak wojciech-piotrowiak marked this pull request as ready for review November 8, 2024 11:47
@wojciech-piotrowiak wojciech-piotrowiak requested a review from a team as a code owner November 8, 2024 11:47
Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. why a new action which looks like a fork of docker-build-image?
  2. this action is so tied to your specific builds that I am becoming concerned that should not be published anymore here under build-tools but on a private repository

@wojciech-piotrowiak
Copy link
Contributor Author

@gionn

  1. it looks like a fork because we need a lot of logic inside however refactoring current action to have backward compatibility will be painful
  2. This new action will be used in at least 3 different repos so I need a common place anyway

@gionn
Copy link
Member

gionn commented Nov 13, 2024

this has been moved to the new internal-build-tools

@gionn gionn closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants