-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AAE-25854 New docker build action #807
Closed
wojciech-piotrowiak
wants to merge
24
commits into
master
from
improvement/AAE-25854-docker-build-with-pull-push-tokens
Closed
AAE-25854 New docker build action #807
wojciech-piotrowiak
wants to merge
24
commits into
master
from
improvement/AAE-25854-docker-build-with-pull-push-tokens
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojciech-piotrowiak
changed the title
AAE-25854 New token inputs for pull and push
AAE-25854 New docker build action
Nov 8, 2024
gionn
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- why a new action which looks like a fork of
docker-build-image
? - this action is so tied to your specific builds that I am becoming concerned that should not be published anymore here under build-tools but on a private repository
|
this has been moved to the new internal-build-tools |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
We faced issue where one token should be used to pull docker images during the build and other one with write permission should be used to push.
Similar approach is used in hxpr: https://github.com/HylandSoftware/hxpr/blob/master/.github/workflows/continuous_integration.yaml#L197
https://github.com/HylandSoftware/hxpr/blob/master/.github/workflows/continuous_integration.yaml#L217
New action does not require keepin backward compability and also forces users to provide ghcr username which is crucial as we want to avoid using ${{ github.actor }}