[PWGJE] Add workflows for charged jet spectra analysis #8884
Conversation
wefeng1110
requested review from
alibuild,
maoyx,
nzardosh,
fjonasALICE,
mfasDa,
mhemmer-cern,
jgrosseo,
iarsene,
ktf,
ddobrigk and
a team
as code owners
github-actions
bot
changed the title
CMakeLists.txt
Outdated
| @@ -1,90 +0,0 @@ | |||
| # Copyright 2019-2020 CERN and copyright holders of ALICE O2. | |||
There was a problem hiding this comment.
what is this file and why was it removed?
There was a problem hiding this comment.
Sorry, I delete this CMakeList.txt by mistake. I will upload it.
PWGJE/Tasks/jetMatchedResponse.cxx
Outdated
| @@ -0,0 +1,392 @@ | |||
| // Copyright 2019-2020 CERN and copyright holders of ALICE O2. | |||
| // See https://alice-o2.web.cern.ch/copyright for details of the copyright holders. | |||
There was a problem hiding this comment.
why is this in a separate task? You can combine it into the same task as the jetSpectraCharged. It is better not to separate the MC and data parts of tasks into multiple files
There was a problem hiding this comment.
Hi Nima, I just combine this matched task with the jetSpectraCharged. but I would like to keep several TH1 and TH2 for track and raw jet(before subtraction) to just confirm i was doing the right cut.
PWGJE/Tasks/jetSpectraCharged.cxx
Outdated
| { | ||
| registry.fill(HIST("h_track_pt"), track.pt(), weight); | ||
| registry.fill(HIST("h2_track_eta_track_phi"), track.eta(), track.phi(), weight); | ||
| registry.fill(HIST("h2_track_pt_track_dcaxy"), track.pt(), track.dcaXY(), weight); |
There was a problem hiding this comment.
this task seems fine but it seems to be a copy of the jetFinderQA in large parts. That is fine to some extent in this case but I am wondering if all of these types of histograms are needed?
|
Hi @wefeng1110 this PR cannot be approved until the formatting test is passed in github since it is required |
|
Hi @nzardosh thank you very much for your reminder, so far my PR has passed all the format tests. |
Add workflows for jet spectra, background study: