Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PWGJE,EMCAL-670] Add time differences into the clusterdefinition #8896

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[PWGJE,EMCAL-670] Add time differences into the clusterdefinition #8896

merged 1 commit into from
Dec 11, 2024

Conversation

mhemmer-cern
Copy link
Collaborator

  • Add the time difference allowed between the seed cell and aggregation cells to be added to a cluster to the struct of the ClusterDefinition
  • Added 500, 100 and 50 ns time diff definitions as varaitions for kV3Default and kV3MostSplit

@alibuild alibuild mentioned this pull request Dec 10, 2024
Closed
@mhemmer-cern
Copy link
Collaborator Author

Local test running, after confirming that everything looks okay, I would merge

@mhemmer-cern
[PWGJE,EMCAL-670] Add time differences into the clusterdefinition
5589e61 
- Add the time difference allowed between the seed cell and aggregation cells to be added to a cluster to the struct of the ClusterDefinition
- Added 500, 100 and 50 ns time diff definitions as varaitions for kV3Default and kV3MostSplit
@mhemmer-cern mhemmer-cern enabled auto-merge (squash) December 11, 2024 09:12
alibuild
alibuild approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @mhemmer-cern.

@mhemmer-cern mhemmer-cern merged commit ea40bb3 into AliceO2Group:master Dec 11, 2024
12 of 13 checks passed
Archita-Dash pushed a commit to Archita-Dash/O2Physics that referenced this pull request Dec 11, 2024
@mhemmer-cern @Archita-Dash
[PWGJE,EMCAL-670] Add time differences into the clusterdefinition (Al…
bf721ae 
…iceO2Group#8896)
hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Dec 20, 2024
@mhemmer-cern
[PWGJE,EMCAL-670] Add time differences into the clusterdefinition (Al…
110a5a0 
…iceO2Group#8896)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alibuild alibuild alibuild approved these changes

@maoyx maoyx Awaiting requested review from maoyx maoyx is a code owner

@nzardosh nzardosh Awaiting requested review from nzardosh nzardosh is a code owner

@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE fjonasALICE is a code owner

@mfasDa mfasDa Awaiting requested review from mfasDa mfasDa is a code owner

Assignees
No one assigned
Labels
datamodel emcal pwgje
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhemmer-cern @alibuild