Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PWGUD] Add few more configurables #9070

Merged
merged 9 commits into from
Dec 20, 2024
Merged

[PWGUD] Add few more configurables #9070

merged 9 commits into from
Dec 20, 2024
+24 −18

Conversation

ananthapadmanabhan18
Copy link
Contributor

Added a Configurable for nBins for pT, phi, costheta, and invariant masses

@github-actions github-actions bot added the pwgud label Dec 19, 2024
@github-actions github-actions bot changed the title Add few more configurables [PWGUD] Add few more configurables Dec 19, 2024
rolavick
rolavick previously approved these changes Dec 19, 2024
View reviewed changes
@rolavick rolavick enabled auto-merge (squash) December 19, 2024 17:36
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 9b53f40 at 2024-12-19 19:53:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/9070-slc9_x86-64/0/PWGUD/Tasks/exclusiveRhoTo4Pi.cxx:91:15: error: narrowing conversion of '((UPCAnalysis*)this)->UPCAnalysis::nBins_pT.o2::framework::Configurable<float>::<anonymous>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::operator float()' from 'float' to 'int' [-Werror=narrowing]
/sw/SOURCES/O2Physics/9070-slc9_x86-64/0/PWGUD/Tasks/exclusiveRhoTo4Pi.cxx:92:15: error: narrowing conversion of '((UPCAnalysis*)this)->UPCAnalysis::nBins_pT.o2::framework::Configurable<float>::<anonymous>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::operator float()' from 'float' to 'int' [-Werror=narrowing]
/sw/SOURCES/O2Physics/9070-slc9_x86-64/0/PWGUD/Tasks/exclusiveRhoTo4Pi.cxx:93:15: error: narrowing conversion of '((UPCAnalysis*)this)->UPCAnalysis::nBins_pT.o2::framework::Configurable<float>::<anonymous>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::operator float()' from 'float' to 'int' [-Werror=narrowing]
/sw/SOURCES/O2Physics/9070-slc9_x86-64/0/PWGUD/Tasks/exclusiveRhoTo4Pi.cxx:96:15: error: narrowing conversion of '((UPCAnalysis*)this)->UPCAnalysis::nBins_pT.o2::framework::Configurable<float>::<anonymous>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::operator float()' from 'float' to 'int' [-Werror=narrowing]
/sw/SOURCES/O2Physics/9070-slc9_x86-64/0/PWGUD/Tasks/exclusiveRhoTo4Pi.cxx:99:15: error: narrowing conversion of '((UPCAnalysis*)this)->UPCAnalysis::nBins_pT.o2::framework::Configurable<float>::<anonymous>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::operator float()' from 'float' to 'int' [-Werror=narrowing]
/sw/SOURCES/O2Physics/9070-slc9_x86-64/0/PWGUD/Tasks/exclusiveRhoTo4Pi.cxx:107:15: error: narrowing conversion of '((UPCAnalysis*)this)->UPCAnalysis::nBins_y.o2::framework::Configurable<float>::<anonymous>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::operator float()' from 'float' to 'int' [-Werror=narrowing]
/sw/SOURCES/O2Physics/9070-slc9_x86-64/0/PWGUD/Tasks/exclusiveRhoTo4Pi.cxx:108:15: error: narrowing conversion of '((UPCAnalysis*)this)->UPCAnalysis::nBins_y.o2::framework::Configurable<float>::<anonymous>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::operator float()' from 'float' to 'int' [-Werror=narrowing]
/sw/SOURCES/O2Physics/9070-slc9_x86-64/0/PWGUD/Tasks/exclusiveRhoTo4Pi.cxx:109:15: error: narrowing conversion of '((UPCAnalysis*)this)->UPCAnalysis::nBins_y.o2::framework::Configurable<float>::<anonymous>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::operator float()' from 'float' to 'int' [-Werror=narrowing]
/sw/SOURCES/O2Physics/9070-slc9_x86-64/0/PWGUD/Tasks/exclusiveRhoTo4Pi.cxx:112:15: error: narrowing conversion of '((UPCAnalysis*)this)->UPCAnalysis::nBins_IM.o2::framework::Configurable<float>::<anonymous>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::operator float()' from 'float' to 'int' [-Werror=narrowing]
/sw/SOURCES/O2Physics/9070-slc9_x86-64/0/PWGUD/Tasks/exclusiveRhoTo4Pi.cxx:113:15: error: narrowing conversion of '((UPCAnalysis*)this)->UPCAnalysis::nBins_IM.o2::framework::Configurable<float>::<anonymous>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::operator float()' from 'float' to 'int' [-Werror=narrowing]
/sw/SOURCES/O2Physics/9070-slc9_x86-64/0/PWGUD/Tasks/exclusiveRhoTo4Pi.cxx:114:15: error: narrowing conversion of '((UPCAnalysis*)this)->UPCAnalysis::nBins_IM.o2::framework::Configurable<float>::<anonymous>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::operator float()' from 'float' to 'int' [-Werror=narrowing]
/sw/SOURCES/O2Physics/9070-slc9_x86-64/0/PWGUD/Tasks/exclusiveRhoTo4Pi.cxx:117:15: error: narrowing conversion of '((UPCAnalysis*)this)->UPCAnalysis::nBins_IM.o2::framework::Configurable<float>::<anonymous>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::operator float()' from 'float' to 'int' [-Werror=narrowing]
/sw/SOURCES/O2Physics/9070-slc9_x86-64/0/PWGUD/Tasks/exclusiveRhoTo4Pi.cxx:118:15: error: narrowing conversion of '((UPCAnalysis*)this)->UPCAnalysis::nBins_IM.o2::framework::Configurable<float>::<anonymous>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::operator float()' from 'float' to 'int' [-Werror=narrowing]
/sw/SOURCES/O2Physics/9070-slc9_x86-64/0/PWGUD/Tasks/exclusiveRhoTo4Pi.cxx:119:15: error: narrowing conversion of '((UPCAnalysis*)this)->UPCAnalysis::nBins_IM.o2::framework::Configurable<float>::<anonymous>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::operator float()' from 'float' to 'int' [-Werror=narrowing]
/sw/SOURCES/O2Physics/9070-slc9_x86-64/0/PWGUD/Tasks/exclusiveRhoTo4Pi.cxx:137:15: error: narrowing conversion of '((UPCAnalysis*)this)->UPCAnalysis::nBins_Phi.o2::framework::Configurable<float>::<anonymous>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::operator float()' from 'float' to 'int' [-Werror=narrowing]
/sw/SOURCES/O2Physics/9070-slc9_x86-64/0/PWGUD/Tasks/exclusiveRhoTo4Pi.cxx:138:15: error: narrowing conversion of '((UPCAnalysis*)this)->UPCAnalysis::nBins_Phi.o2::framework::Configurable<float>::<anonymous>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::operator float()' from 'float' to 'int' [-Werror=narrowing]
/sw/SOURCES/O2Physics/9070-slc9_x86-64/0/PWGUD/Tasks/exclusiveRhoTo4Pi.cxx:139:15: error: narrowing conversion of '((UPCAnalysis*)this)->UPCAnalysis::nBins_CosTheta.o2::framework::Configurable<float>::<anonymous>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::operator float()' from 'float' to 'int' [-Werror=narrowing]
/sw/SOURCES/O2Physics/9070-slc9_x86-64/0/PWGUD/Tasks/exclusiveRhoTo4Pi.cxx:140:15: error: narrowing conversion of '((UPCAnalysis*)this)->UPCAnalysis::nBins_CosTheta.o2::framework::Configurable<float>::<anonymous>.o2::framework::ConfigurablePolicyConst<float, o2::framework::kGeneric>::operator float()' from 'float' to 'int' [-Werror=narrowing]
ninja: build stopped: subcommand failed.

Full log here.

auto-merge was automatically disabled December 20, 2024 04:47

Head branch was pushed to by a user without write access

@rolavick
Copy link
Collaborator

Hi @ananthapadmanabhan18 I approve it but please consider the changes suggested by O2 linter for your next PR.

@rolavick rolavick merged commit 9a784c0 into AliceO2Group:master Dec 20, 2024
18 of 20 checks passed
@ananthapadmanabhan18
Copy link
Contributor Author

Sure @rolavick !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolavick rolavick rolavick approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@pbuehler pbuehler Awaiting requested review from pbuehler pbuehler is a code owner

@abylinkin abylinkin Awaiting requested review from abylinkin abylinkin is a code owner

Assignees
No one assigned
Labels
pwgud
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ananthapadmanabhan18 @alibuild @rolavick