[WIP] [QC-858] Single CheckRunner per workflow #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1b9206b.
Barthelemy
changed the title
knopers8
requested changes
Dec 20, 2023
| @@ -85,6 +85,17 @@ TEST_CASE("qc_factory_local_test") | |||
| } | |||
| } | |||
|
|
|||
| TEST_CASE("onlyTask") | |||
There was a problem hiding this comment.
I think this is tested in the testSharedConfig.json as well, "defTask" and "recoTask" do not have associated checks there. I guess we did not discover it was wrong previously because of the wrong update of qc-check's expected number of inputs.
Up to you if you want to remove this one though.
| const auto configTree = configInterface->getRecursive(); | ||
| const auto workflow = InfrastructureGenerator::generateStandaloneInfrastructure(configTree); | ||
| // the infrastructure should consist of 1 TaskRunners, 1 CheckRunner | ||
| REQUIRE(workflow.size() == 2); |
There was a problem hiding this comment.
please also check the number of inputs so they match with the number of tasks without checks. In fact, I do not quite understand where do you add them to the CheckRunner, to me it still seems wrong.
Barthelemy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1b9206b.