Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPC QC: Update utility for timestamp extraction to optimize it #2432

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

lauraser
Copy link
Contributor

  • switches for IDC task what to plot

@lauraser lauraser requested a review from wiechula as a code owner September 23, 2024 17:21
Modules/TPC/src/IDCs.cxx Outdated Show resolved Hide resolved
Modules/TPC/src/IDCs.cxx Outdated Show resolved Hide resolved
Modules/TPC/src/Utility.cxx Outdated Show resolved Hide resolved
@lauraser lauraser force-pushed the master branch 2 times, most recently from af6f497 to 3f5667e Compare September 25, 2024 10:26
@lauraser lauraser changed the title Update utility for timestamp extraction to optimize it TPC QC: Update utility for timestamp extraction to optimize it Sep 25, 2024
@lauraser
Copy link
Contributor Author

@wiechula I implemented all your suggestions. Regarding the call .list() for last two weeks, I also additionally added checks if at least one object version was found. If not, then files are not retreived (otherwise there is seg fault). Please, let me know if you want any additional changes

@Barthelemy
Copy link
Collaborator

@wiechula @lauraser We need to release QC this morning and this is the last release before the freeze. We can do adhoc patches afterward yet we should aim at merging this PR this morning.
Could you approve and merge ?
thank you

@wiechula wiechula merged commit fa48f59 into AliceO2Group:master Sep 26, 2024
7 checks passed
@wiechula
Copy link
Collaborator

@Barthelemy , done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants