Common: improve layout of 1-D reference plot comparisons #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new layout puts the ratio plot above the two superimposed histograms, and avoids the presence of a transparent pad above the histograms. This restores the possibility to see the bin values by hovering the mouse pointer over the histogram, as well as of zooming the horizontal axis with the mouse.
aferrero2707
requested review from
Barthelemy,
knopers8 and
justonedev1
as code owners
|
@Barthelemy @knopers8 this is a visual improvement that was requested after some detectors started to use the reference comparison task. |
Barthelemy
approved these changes
Sep 24, 2024
aferrero2707
deleted the
common-improve-th1-reference-comparison-plot-layout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new layout puts the ratio plot above the two superimposed histograms, and avoids the presence of a transparent pad above the histograms. This restores the possibility to see the bin values by hovering the mouse pointer over the histogram, as well as of zooming the horizontal axis with the mouse.
Here is an example of the new plots arrangement, for different aspect ratios of the canvas:
