Common: correctly handle integer histograms in reference comparator #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reference comparator code is extended to handle histograms with integer values, by internally converting them to floating-point such that the normalization and ratios are computed correctly
aferrero2707
requested review from
Barthelemy,
knopers8 and
justonedev1
as code owners
|
@knopers8 this is the extension we discussed for the ZDC plots. |
aferrero2707
deleted the
common-support-integer-histograms-in-reference-comparator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reference comparator code is extended to handle histograms with integer values, by internally converting them to floating-point such that the normalization and ratios are computed correctly