Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Develop OpenHands with OpenHands #4368

Closed
wants to merge 2 commits into from

Conversation

qiangli
Copy link
Contributor

@qiangli qiangli commented Oct 14, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

  • Provide docker files and scripts for building custom sandbox which supports building/running docker.
  • Make target and scripts for building OpenHands using OpenHands. make start-oh-dev is all one needs to get started.
  • Add runtime_extra_options to sandbox config for supporting all supported docker run options.
  • Introduce <workspace>/.openhands.toml for workspace specific configurations
  • minor code change to support the above features.

Last but not least, "summary of change" in the last commit was generated and commited by OpenHands as a test at my prompt.


Link of any specific issues this addresses

@rbren
Copy link
Collaborator

rbren commented Oct 14, 2024

@qiangli thanks for putting this together! Lots of good stuff in here, but also seems like maybe a lot to maintain, and a lot that would need to be configured per environment.

Will get back to you with some more concrete feedback

Introduce new sandbox.runtime_extra_options setting for running sandbox
All docker run options can now be passed on to sandbox except for the following:
command, working_dir, name, detach.
Add make target for developing OpenHands with OpenHands

Summary of changes:
- New File: Added .openhands.toml with configuration settings for core, sandbox, and LLM.
- Development Documentation: Updated Development.md to include instructions for developing OpenHands with OpenHands.
- Makefile:
  - Added FRONTEND_HOST variable.
  - Modified frontend start commands to include --host option.
  - Added targets start-oh-dev and stop-oh-dev for developing OpenHands with OpenHands.
  - Updated .PHONY targets to include new commands.
- Compose File: Updated compose.yml with new environment variables and configurations.
- Runtime Client: Enhanced logging and configuration handling in openhands/runtime/client/runtime.py.
@qiangli
Copy link
Contributor Author

qiangli commented Oct 28, 2024

closing this one in favor of #4588 - a much simpler, cleaner, and more powerful approach.
Let me know what you think @rbren thanks!

@qiangli qiangli closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants