Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add ability to reconnect websockets #4526

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tofarr
Copy link
Collaborator

@tofarr tofarr commented Oct 23, 2024

When the websocket is disconnected in the frontend, the UI displays this users are given a button to reconnect.

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

For the moment, the button just does a page refresh, but I could see a future where it calls a context created in the App component.
image
image

@rbren
Copy link
Collaborator

rbren commented Oct 23, 2024

@tofarr I'd rather not expose this to the user. 99% of the time we should be able to auto-reconnect (e.g. if a pod rolls or we do a new deployment, they can connect to a different pod seamlessly)

If the socket is disconnected and stays disconnected though, having the Disconnected message seems good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants