-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runtime): Add prototype Runloop runtime impl #4598
base: main
Are you sure you want to change the base?
Conversation
plugins, | ||
env_vars, | ||
status_message_callback, | ||
attach_to_existing, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to make better use of this var--we use it pretty aggressively now. We create several Runtime objects within a session, and they all need to get access to the same runtime.
Can we track the runtime on runloop by sid
, so that we can retrieve it if available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes - so essentially, if attach_to_existing
, we should look up by sid
and first try to use the existing sandbox. is that the correct understanding? if so, I will get that in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup exactly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great - do you know if any tests cover this flow? i didn't see at first glance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm no I don't think we actually have integration tests here! We definitely should...
End-user friendly description of the problem this fixes or functionality that this introduces
Add Runloop runtime implementation on top of
EventStreamRuntime
Give a summary of what the PR does, explaining any non-trivial design decisions
This PR adds a Runloop runtime implementation, primarily utilizing
EventStreamRuntime
and its associated communication mechanismsThis runtime:
Devbox
will use a pre-built openhands sandbox image built againstdockerfile.j2
run_action
) toEventStreamRuntime
Also included is a polling based
LogBuffer
Link of any specific issues this addresses