Introduced flag for keeping VMs alive #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javihernandez
approved these changes
Dec 13, 2024
anfimovdm
requested changes
Dec 17, 2024
alts/worker/tasks.py
Outdated
| @@ -174,6 +174,7 @@ def set_artifacts_when_stage_has_unexpected_exception( | |||
| module_name = task_params.get('module_name') | |||
| module_stream = task_params.get('module_stream') | |||
| module_version = task_params.get('module_version') | |||
| vm_alive = task_params.get('vm_alive') | |||
There was a problem hiding this comment.
let's pass it as a keyword argument as we do above and adjust OpennebulaRunner.teardown method to not kill VMs
because right now, if that value is True we won't kill docker containers as well
There was a problem hiding this comment.
I made adjustment but as I understand we need also to pass this flag to DockerRunner in order to avoid an exception during initialization.
anfimovdm
requested changes
Dec 24, 2024
alts/worker/runners/opennebula.py
Outdated
| @@ -62,6 +63,7 @@ def __init__( | |||
| package_channel=package_channel, | |||
| test_configuration=test_configuration, | |||
| test_flavor=test_flavor, | |||
| vm_alive= vm_alive, | |||
There was a problem hiding this comment.
please remove whitespace before vm_alive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://cloudlinux.atlassian.net/browse/AL-5654
Fronend and backend: https://gerrit.cloudlinux.com/c/build-system/+/181258