Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport production changes #111

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Backport production changes #111

merged 1 commit into from
Dec 18, 2024

Conversation

anfimovdm
Copy link
Contributor

No description provided.

javihernandez
javihernandez approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@javihernandez javihernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one thing. Since this commit only fixes the problem about the non-numeric bs_task_id, can you please adjust the commit message accordingly? Something like allow non-numeric bs_task_id or the like?

@javihernandez javihernandez merged commit 5291435 into cl Dec 18, 2024
2 of 3 checks passed
@anfimovdm anfimovdm deleted the cl_backport branch December 24, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Korulag Korulag Korulag approved these changes

@javihernandez javihernandez javihernandez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anfimovdm @javihernandez @Korulag