Cleaning up remaining todo's in the code #572
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
elpiel
force-pushed
the
clean-up-todos
branch
from
f6af18d to
5702036
Compare
elpiel
requested changes
Nov 25, 2022
| @@ -961,6 +955,69 @@ mod test { | |||
| ); | |||
| } | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_unified_num_mod_floor_gcd_lcm_divides_is_multiple_of_div_rem() { | |||
There was a problem hiding this comment.
I'm uncertain about these tests. You're actually checking 0.00000008 value in the first test for example, not integers so the math is different for floating numbers.
Another things I realised is that num::Integer allows these methods and it's not implemented for floating numbers, so maybe we don't need to include Integer impl for UnitfiedNum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #570